Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][FlatList] Objects as props trigger invariant errors #16776

Closed
wants to merge 3 commits into from
Closed

[Bugfix][FlatList] Objects as props trigger invariant errors #16776

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6700c9b
fix shallow compare bugs
eballeste Nov 9, 2017
9a2bada
prettier
eballeste Nov 23, 2017
db06d53
prettier updates
eballeste Nov 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Libraries/Lists/FlatList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const View = require('View');
const VirtualizedList = require('VirtualizedList');

const invariant = require('fbjs/lib/invariant');
const areEqual = require('fbjs/lib/areEqual');

import type {StyleObj} from 'StyleSheetTypes';
import type {
Expand Down Expand Up @@ -419,16 +420,21 @@ class FlatList<ItemT> extends React.PureComponent<Props<ItemT>, void> {
'changing the number of columns to force a fresh render of the component.',
);
invariant(
nextProps.onViewableItemsChanged === this.props.onViewableItemsChanged,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace nextProps.onViewableItemsChanged,·this.props.onViewableItemsChanged with ⏎········nextProps.onViewableItemsChanged,⏎········this.props.onViewableItemsChanged,⏎······

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

areEqual(
nextProps.onViewableItemsChanged,
this.props.onViewableItemsChanged
),
'Changing onViewableItemsChanged on the fly is not supported',
);
invariant(
nextProps.viewabilityConfig === this.props.viewabilityConfig,
areEqual(nextProps.viewabilityConfig, this.props.viewabilityConfig),
'Changing viewabilityConfig on the fly is not supported',
);
invariant(
nextProps.viewabilityConfigCallbackPairs ===
this.props.viewabilityConfigCallbackPairs,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace nextProps.viewabilityConfigCallbackPairs,·this.props.viewabilityConfigCallbackPairs with ⏎········nextProps.viewabilityConfigCallbackPairs,⏎········this.props.viewabilityConfigCallbackPairs,⏎······

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it pointing to the prev version of the diff?

areEqual(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-trailing-spaces: Trailing spaces not allowed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Delete ·

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

nextProps.viewabilityConfigCallbackPairs,
this.props.viewabilityConfigCallbackPairs
),
'Changing viewabilityConfigCallbackPairs on the fly is not supported',
);

Expand Down