Corrected types of page_info return value in documentation. #16830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Can you sign the cla? |
|
@chirag04, I've signed it now. |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 20, 2017
There was a problem hiding this comment.
@chirag04 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in facebook#15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes facebook#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in facebook#15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes facebook#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 23, 2019
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in #15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes facebook/react-native#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 24, 2019
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in #15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes facebook/react-native#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was confused by the current documentation, as it was requesting me to pass the previously received
end_cursorinto the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs.I tried to push this change back in #15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR.
Test Plan
This is a change to documentation only.
Release Notes
[DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the
start_cursorandend_cursorvalues.