Set minHeight instead of minWidth for calculating the layout in RCTSurfaceRootShadowView #17203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TSurfaceRootShadowView
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
@shergin Hey - could you please take a look at this PR. If this would go into a public release we would have to manually patch it in this release if we would like to use it. Thanks! |
|
@maicki Oh, sorry, I missed this. Sure! |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 28, 2017
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@maicki Just curious, where do you use this? 😄 |
mathiasbynens
pushed a commit
to mathiasbynens/react-native
that referenced
this pull request
Jan 13, 2018
…rfaceRootShadowView Summary: Fix calculating layout in `RCTSurfaceRootShadowView` as the `minWidth` is set doubled in `calculateLayoutWithMinimumSize:maximumSize:`. cc shergin Closes facebook#17203 Differential Revision: D6642437 Pulled By: shergin fbshipit-source-id: 3483c952c9ecf0132182a156b7b916eb1e975424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix calculating layout in
RCTSurfaceRootShadowViewas theminWidthis set doubled incalculateLayoutWithMinimumSize:maximumSize:.cc @shergin