Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1562 Rename 'tick' to 'onTick' to pass iTunes Connect validation. #1722

Closed
wants to merge 1 commit into from
Closed

Conversation

admmasters
Copy link
Contributor

Should close this issue and successfully pass iTunes Connect validation.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2015
@brentvatne
Copy link
Collaborator

Looks good to me, I'm not crazy about the name onTick (I know, I know, I suggested it :P) now that I see it in context but no need to bikeshed here.

@tadeuzagallo
Copy link
Contributor

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/406409676212526/int_phab to review.

@a2 a2 closed this in cf6ff3f Jul 2, 2015
@ptmt
Copy link
Contributor

ptmt commented Jul 10, 2015

Thanks, that warning was a bit annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants