Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs page for accessibility support #1726

Merged
merged 4 commits into from
Jun 25, 2015
Merged

Conversation

a2
Copy link
Contributor

@a2 a2 commented Jun 23, 2015

After working with Georgiy on adding a bunch of accessibility support to React Native, it seemed fitting to add a docs page to illustrate how developers can leverage this new support in their React Native apps.

@a2
Copy link
Contributor Author

a2 commented Jun 23, 2015

Would love feedback on anything that needs clarification or updating.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2015
@@ -0,0 +1,75 @@
---
id: accesibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "s"

<View style={styles.button}>
<Text style={styles.buttonText}>Press me!</Text>
</View>
</TouchableOpacity>```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The triple backtick here needs to be on a newline 😄

@brentvatne
Copy link
Collaborator

Looks great @a2! Added some feedback for you, looking forward to getting this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants