-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SectionList renderItem should be optional #17262
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Thanks for the fix! @facebook-github-bot shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: `renderItem` on `SectionList` is within the `OptionalProps` group of props but it is not actually marked as optional. Which means that doing things such as in the example where each section has its own `renderItem` and no `renderItem` prop is passed into `SectionList` will fail flow. Create a `SectionList` where each section has it's own `renderItem` and do not pass in a `renderItem` into `SectionList`. Run flow, it should error. [GENERAL] [MINOR] [SectionList] -Makes `renderItem` prop on `SectionList` optional for flow. Closes facebook#17262 Differential Revision: D6645672 Pulled By: hramos fbshipit-source-id: 1096e8c4998c14003cf42f29ea559505082047c1
Motivation
renderItem
onSectionList
is within theOptionalProps
group of props but it is not actually marked as optional. Which means that doing things such as in the example where each section has its ownrenderItem
and norenderItem
prop is passed intoSectionList
will fail flow.Test Plan
Create a
SectionList
where each section has it's ownrenderItem
and do not pass in arenderItem
intoSectionList
. Run flow, it should error.Release Notes
[GENERAL] [MINOR] [SectionList] -Makes
renderItem
prop onSectionList
optional for flow.