Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SectionList renderItem should be optional #17262

Closed
wants to merge 2 commits into from
Closed

SectionList renderItem should be optional #17262

wants to merge 2 commits into from

Conversation

shichongrui
Copy link

@shichongrui shichongrui commented Dec 18, 2017 •
edited by janicduplessis
Loading

Motivation

renderItem on SectionList is within the OptionalProps group of props but it is not actually marked as optional. Which means that doing things such as in the example where each section has its own renderItem and no renderItem prop is passed into SectionList will fail flow.

Test Plan

Create a SectionList where each section has it's own renderItem and do not pass in a renderItem into SectionList. Run flow, it should error.

Release Notes

[GENERAL] [MINOR] [SectionList] -Makes renderItem prop on SectionList optional for flow.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

Warnings
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2017
@pull-bot
Copy link

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

@janicduplessis
Copy link
Contributor

Thanks for the fix!

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Dec 29, 2017
facebook-github-bot
facebook-github-bot approved these changes Dec 29, 2017
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mathiasbynens pushed a commit to mathiasbynens/react-native that referenced this pull request Jan 13, 2018
@mathiasbynens
SectionList renderItem should be optional
9fd432d 
Summary:
`renderItem` on `SectionList` is within the `OptionalProps` group of props but it is not actually marked as optional. Which means that doing things such as in the example where each section has its own `renderItem` and no `renderItem` prop is passed into `SectionList` will fail flow.

Create a `SectionList` where each section has it's own `renderItem` and do not pass in a `renderItem` into `SectionList`. Run flow, it should error.

[GENERAL] [MINOR] [SectionList] -Makes `renderItem` prop on `SectionList` optional for flow.
Closes facebook#17262

Differential Revision: D6645672

Pulled By: hramos

fbshipit-source-id: 1096e8c4998c14003cf42f29ea559505082047c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janicduplessis janicduplessis janicduplessis approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shichongrui @facebook-github-bot @pull-bot @janicduplessis