Xcode 9 supports running multiple simulators #17284

koenpunt · 2017-12-20T08:52:08Z

Motivation

Since Xcode 9 you can run multiple simultaneously. And since I believe React Native advocates using the latest version of Xcode, we can safely remove this constraint.

Test Plan

Updated the unit tests. Furthermore it can be found in the Xcode release notes that multiple simulators are now supported.

This can be tested with the CLI by running react-native run-ios twice, but with a different --simulator flag, e.g.;

react-native run-ios --simulator "iPhone SE"
react-native run-ios --simulator "iPhone X"

Release Notes

[IOS] [ENHANCEMENT] [local-cli/runIOS/findMatchingSimulator.js] - Allow running multiple simulators

eslint-bot · 2017-12-20T10:15:46Z

local-cli/runIOS/runIOS.js

-      // but we want it to only launch the simulator
-    }
+    child_process.spawnSync('xcrun', ['simctl', 'boot', selectedSimulator.udid]);
+    console.log(selectedSimulator)


semi: Missing semicolon.

koenpunt · 2018-01-03T16:37:58Z

Ping ✨ @hramos almost all green now! (failing tests are not related to my changes I assume)

ide · 2018-01-03T21:20:42Z

local-cli/runIOS/runIOS.js

-  .then((appName) => {
+  .then((udid) => new Promise((resolve) => {
+    buildProject(xcodeProject, udid, scheme, args.configuration, args.packager, args.verbose)
+      .then((appName) => resolve(udid, appName));


this resolve call looks buggy

I kind of agree, wasn't really happy with it either, but couldn't really think of a better way.. So I'm open to suggestions :)

Oh now that I look at it again I think I can simply move the buildProject call into the first promise. Let me try

I've moved the invocation of buildProject into the first promise. But now I wonder why it wasn't there in the first place..

Another option would be to add the udid to the resolve call in buildProject, but that doesn't feel right either.

grabbou

Thanks for the PR. Looks really good! However, many people that I've met are still on an older version. For time being, can we check for the version with something like:

$ /usr/bin/xcodebuild -version

and decide to proceed / warn? Alternatively, can we log a message in case of run-ios failing that it was expected on Xcode < 9?

In the future, we might want to drop it.

koenpunt · 2018-01-05T16:21:25Z

However, many people that I've met are still on an older version.

Well as far as I know there shouldn't be a problem if they do not give a --simulator flag to the run-ios command, since then it will just default to the booted one.

Altho I'm not completely sure what happens if they do specify one when there's another booted already, and that's hard to test since I'm no longer having Xcode 8.

But again, I think we should move forward, Xcode 9 has been around for over 3 months, this might be another good reason to upgrade.

koenpunt · 2018-01-05T16:26:13Z

Oh but this I can do:

can we log a message in case of run-ios failing that it was expected on Xcode < 9?

ide · 2018-01-05T18:11:42Z

@shergin Does Facebook use Xcode 8 anymore? That'd help inform whether to keep legacy support around.

shergin · 2018-01-05T22:53:06Z

@ide Facebook does not use run-ios at all, afaik. And, honestly, I have no idea how it works.
So, I think, as soon OSS core community (@grabbou, @janicduplessis, someone else) can reach a consensus about this change, I can land it. (This is usually also true for many PRs here.)

facebook-github-bot · 2018-02-04T18:04:41Z

@koenpunt I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

koenpunt · 2018-02-05T12:51:50Z

Ping ✨

koenpunt · 2018-02-14T21:26:18Z

@grabbou FYI; just brought my branch up-to-date with master

hramos · 2018-02-16T21:22:29Z

Can you take a look at the failing tests? We recently got all tests passing. If you're sure the failure is unrelated, at least rebase the PR. That will trigger tests to run again.

move buildProject invocation

to guide users with Xcode < 9 we now throw an informative error that running multiple simulators is only support in Xcode 9 and up

also changed spawnSync to execFileSync, because spawnSync didn't throw

koenpunt · 2018-02-17T12:32:24Z

@hramos tests are passing now. js_checks isn't, but I'm pretty sure that's unrelated.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: PR #17284 (accepted in 2ad3407) introduced a couple of regressions. ~1. There's the code:~ ``` .then((appName) => resolve(selectedSimulator.udid, appName)); /* ... */ .then((udid, appName) => { ``` ~~This makes `appName` to be always `undefined` as per `resolve` accepts only 1 argument. This regression causes issues if an app name differs from a scheme name.~ ~This PR fixes this by wrapping both values in an array.~ This was fixed in 589eae1. 2. The code ``` child_process.execFileSync('xcrun', ['simctl', 'boot', selectedSimulator.udid]); ``` makes a simulator *boot*, but the simulator *doesn't launch*. That's a regression, which forces developers to launch simulators by other means (by running a number of elaborate console commands, by running Xcode, or by running a simulator manually). This PR reverts that part of changes. Create a blank project with a name that differs from scheme name. Try to `react-native run-ios` in it. See that a simulator is launched and installing succeeds. Without this changes simulator wouldn't launch, and installing step would fail because of app name mismatch. [CLI][BUGFIX][local-cli/runIOS/runIOS.js] - Fix running on multiple simulators feature regressions Closes #18711 Differential Revision: D7535150 Pulled By: hramos fbshipit-source-id: 5c714231e9977c0c829b6f8c793497cd31cd46b5

Summary: PR facebook#17284 (accepted in 2ad3407) introduced a couple of regressions. ~1. There's the code:~ ``` .then((appName) => resolve(selectedSimulator.udid, appName)); /* ... */ .then((udid, appName) => { ``` ~~This makes `appName` to be always `undefined` as per `resolve` accepts only 1 argument. This regression causes issues if an app name differs from a scheme name.~ ~This PR fixes this by wrapping both values in an array.~ This was fixed in 589eae1. 2. The code ``` child_process.execFileSync('xcrun', ['simctl', 'boot', selectedSimulator.udid]); ``` makes a simulator *boot*, but the simulator *doesn't launch*. That's a regression, which forces developers to launch simulators by other means (by running a number of elaborate console commands, by running Xcode, or by running a simulator manually). This PR reverts that part of changes. Create a blank project with a name that differs from scheme name. Try to `react-native run-ios` in it. See that a simulator is launched and installing succeeds. Without this changes simulator wouldn't launch, and installing step would fail because of app name mismatch. [CLI][BUGFIX][local-cli/runIOS/runIOS.js] - Fix running on multiple simulators feature regressions Closes facebook#18711 Differential Revision: D7535150 Pulled By: hramos fbshipit-source-id: 5c714231e9977c0c829b6f8c793497cd31cd46b5

yosimasu · 2018-06-27T07:08:49Z

@koenpunt

The default value of --simulator should be null, or the booted device never be used.

Summary: PR facebook#17284 (accepted in 2ad3407) introduced a couple of regressions. ~1. There's the code:~ ``` .then((appName) => resolve(selectedSimulator.udid, appName)); /* ... */ .then((udid, appName) => { ``` ~~This makes `appName` to be always `undefined` as per `resolve` accepts only 1 argument. This regression causes issues if an app name differs from a scheme name.~ ~This PR fixes this by wrapping both values in an array.~ This was fixed in 589eae1. 2. The code ``` child_process.execFileSync('xcrun', ['simctl', 'boot', selectedSimulator.udid]); ``` makes a simulator *boot*, but the simulator *doesn't launch*. That's a regression, which forces developers to launch simulators by other means (by running a number of elaborate console commands, by running Xcode, or by running a simulator manually). This PR reverts that part of changes. Create a blank project with a name that differs from scheme name. Try to `react-native run-ios` in it. See that a simulator is launched and installing succeeds. Without this changes simulator wouldn't launch, and installing step would fail because of app name mismatch. [CLI][BUGFIX][local-cli/runIOS/runIOS.js] - Fix running on multiple simulators feature regressions Closes facebook#18711 Differential Revision: D7535150 Pulled By: hramos fbshipit-source-id: 5c714231e9977c0c829b6f8c793497cd31cd46b5

Summary: Since Xcode 9 you can run multiple simultaneously. And since I believe React Native advocates using the latest version of Xcode, we can safely remove this constraint. Updated the unit tests. Furthermore it can be found in the [Xcode release notes](https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/WhatsNewXcode/xcode_9/xcode_9.html#//apple_ref/doc/uid/TP40004626-CH8-SW12) that multiple simulators are now supported. This can be tested with the CLI by running `react-native run-ios` twice, but with a different `--simulator` flag, e.g.; react-native run-ios --simulator "iPhone SE" react-native run-ios --simulator "iPhone X" [IOS] [ENHANCEMENT] [local-cli/runIOS/findMatchingSimulator.js] - Allow running multiple simulators Closes facebook/react-native#17284 Differential Revision: D7102790 Pulled By: hramos fbshipit-source-id: 750e7039201e28a1feda2bec1e78144fd9deff98

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2017

eslint-bot reviewed Dec 20, 2017

View reviewed changes

hramos added Platform: iOS iOS applications. Tooling labels Dec 22, 2017

chirag04 requested a review from grabbou January 3, 2018 16:44

ide reviewed Jan 3, 2018

View reviewed changes

grabbou suggested changes Jan 4, 2018

View reviewed changes

hysan mentioned this pull request Jan 6, 2018

Choose Simulator iOS version #10288

Closed

grabbou approved these changes Jan 8, 2018

View reviewed changes

koenpunt added 9 commits February 17, 2018 13:23

Xcode 9 supports running multiple simulators

91d5c85

update tests

7ed9d5c

give booted simulator precedence

0fb9b15

update expected outcome

7bce500

return on first booted device

9befecf

use resolved simulator udid to boot, install and launch

abf9f99

move buildProject invocation

throw error when booting simulator fails

ae9ba43

to guide users with Xcode < 9 we now throw an informative error that running multiple simulators is only support in Xcode 9 and up

only try booting a non-booted simulator

a718892

also changed spawnSync to execFileSync, because spawnSync didn't throw

update tests for booted property

95a8dc3

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 27, 2018

facebook-github-bot approved these changes Feb 27, 2018

View reviewed changes

facebook-github-bot closed this in 2ad3407 Feb 27, 2018

koenpunt deleted the patch-3 branch February 28, 2018 15:45

lebedev mentioned this pull request Apr 5, 2018

Fix launching iOS simulator regression #18711

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Xcode 9 supports running multiple simulators #17284

Xcode 9 supports running multiple simulators #17284

koenpunt commented Dec 20, 2017 •

edited

Loading

eslint-bot Dec 20, 2017

koenpunt commented Jan 3, 2018

ide Jan 3, 2018

koenpunt Jan 3, 2018 •

edited

Loading

koenpunt Jan 3, 2018 •

edited

Loading

koenpunt Jan 4, 2018

koenpunt Jan 4, 2018

grabbou left a comment •

edited

Loading

koenpunt commented Jan 5, 2018

koenpunt commented Jan 5, 2018

ide commented Jan 5, 2018

shergin commented Jan 5, 2018

facebook-github-bot commented Feb 4, 2018

koenpunt commented Feb 5, 2018

koenpunt commented Feb 14, 2018

hramos commented Feb 16, 2018

koenpunt commented Feb 17, 2018

facebook-github-bot left a comment

yosimasu commented Jun 27, 2018

Xcode 9 supports running multiple simulators #17284

Xcode 9 supports running multiple simulators #17284

Conversation

koenpunt commented Dec 20, 2017 • edited Loading

Motivation

Test Plan

Release Notes

eslint-bot Dec 20, 2017

Choose a reason for hiding this comment

koenpunt commented Jan 3, 2018

ide Jan 3, 2018

Choose a reason for hiding this comment

koenpunt Jan 3, 2018 • edited Loading

Choose a reason for hiding this comment

koenpunt Jan 3, 2018 • edited Loading

Choose a reason for hiding this comment

koenpunt Jan 4, 2018

Choose a reason for hiding this comment

koenpunt Jan 4, 2018

Choose a reason for hiding this comment

grabbou left a comment • edited Loading

Choose a reason for hiding this comment

koenpunt commented Jan 5, 2018

koenpunt commented Jan 5, 2018

ide commented Jan 5, 2018

shergin commented Jan 5, 2018

facebook-github-bot commented Feb 4, 2018

koenpunt commented Feb 5, 2018

koenpunt commented Feb 14, 2018

hramos commented Feb 16, 2018

koenpunt commented Feb 17, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

yosimasu commented Jun 27, 2018

koenpunt commented Dec 20, 2017 •

edited

Loading

koenpunt Jan 3, 2018 •

edited

Loading

koenpunt Jan 3, 2018 •

edited

Loading

grabbou left a comment •

edited

Loading