Update Docker images to latest Android SDK, Buck #17313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mathiasbynens
pushed a commit
to mathiasbynens/react-native
that referenced
this pull request
Jan 13, 2018
Summary: Test Plan Rebuilt Docker images locally, confirmed successful image build. Can later be reproed with ``` npm run test-android-setup npm run test-android-build npm run test-android-run-unit-tests ``` Note that unit tests are failing in master, but in this PR we can repro the same failure. Closes facebook#17313 Differential Revision: D6624899 Pulled By: hramos fbshipit-source-id: 42b8cd708ec2a02399bb6ef30fd73faba2646f79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Rebuilt Docker images locally, confirmed successful image build.
Can later be reproed with
Note that unit tests are failing in master, but in this PR we can repro the same failure.