Fix: Avoid contentInsets overwrites scrollIndicatorInsets on iOS #13025

[timotew]

Fix to avoid contentInsets always overwrites scrollIndicatorInsets of ScrollView/ListView.
According to issue #13025

react-native/React/Views/RCTView.m

Line 299 in a8391bd

+ (void)autoAdjustInsetsForView:(UIView<RCTAutoInsetsProtocol> *)parentView

always overide scrollIndicatorInsets when called and only works when contentInsets is not set.
We only need to worry about when contentInsets is set, We only have to check and reset it after autoAdjustInsetsForView is called.

Motivation

Fix: #13025

Test Plan

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)

Release Notes

[pull-bot]

@facebook-github-bot label Android

Generated by 🚫 dangerJS

[timotew]

@hramos Hi there! Are these changes allowed?

[hramos]

@timotew do you have a test plan?

[timotew]

@hramos my team has been using this branch every since.
I will try to add a screenshot.

[brentvatne]

this is definitely a bug (I repro'd it on https://snack.expo.io/S1eOAIRrM -- scrollIndicatorInsets is completely ignored if contentInset is specified). i don't think this is the best fix, though. we should probably change RCTView.autoAdjustInsetsForView so that it doesn't reset scrollIndicatorInsets to baseInset if the scrollview has a scrollIndicatorInsets prop set on it

[timotew]

@brentvatne that was my initial approach but I was considering the effects on other components that make use of autoAdjustInsectsForViews.

[brentvatne]

@timotew - I see.

I'm also concerned because scrollIndicatorInsets doesn't even seem to be in scope here? did you run this code? looks like it was made from Github directly

[timotew]

@brentvatne yes. I did this before the pull as you can see I had to rebase the branch then try the other approach. I later revert back to this. What fix do you think will be best and won't affect other components?

[facebook-github-bot]

@timotew I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.