Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terminal title to 'Metro Bundler' #17457

Closed
wants to merge 3 commits into from
Closed

Update terminal title to 'Metro Bundler' #17457

wants to merge 3 commits into from

Conversation

edcs
Copy link
Contributor

@edcs edcs commented Jan 5, 2018 •
edited
Loading

Motivation

I noticed in v0.50.0 all mentions of 'packager' were updated to 'Metro Bundler':

12eb04b

It seems like command which launches the bundler still sets the terminal title to 'React Packager'. This PR simply updates the title from 'React Packager' to 'Metro Bundler'.

Test Plan

Run scripts/launchPackager.command/scripts/launchPackager.bat and check title:

screen shot 2018-01-05 at 14 02 53

Release Notes

[GENERAL] [ENHANCEMENT] [./scripts]

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@edcs edcs changed the title Update console title to 'Metro Bundler' Update terminal title to 'Metro Bundler' Jan 5, 2018
@pull-bot
Copy link

pull-bot commented Jan 5, 2018 •
edited
Loading

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 8, 2018
facebook-github-bot
facebook-github-bot approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@turnrye
Copy link
Contributor

turnrye commented Jan 8, 2018 •
edited
Loading

@edcs this was renamed again in 654fed4 (which is in 0.52.0-RC) to just "Metro"; think we should skip straight to that?

mathiasbynens pushed a commit to mathiasbynens/react-native that referenced this pull request Jan 13, 2018
@edcs @mathiasbynens
Update terminal title to 'Metro Bundler'
266fa83 
Summary:
I noticed in v0.50.0 all mentions of 'packager' were updated to 'Metro Bundler':

facebook@12eb04b

It seems like command which launches the bundler still sets the terminal title to 'React Packager'. This PR simply updates the title from 'React Packager' to 'Metro Bundler'.

Run `scripts/launchPackager.command`/`scripts/launchPackager.bat` and check title:

<img width="907" alt="screen shot 2018-01-05 at 14 02 53" src="https://user-images.githubusercontent.com/754498/34612337-3e93e8ca-f221-11e7-98f9-c5190674868e.png">

[GENERAL] [ENHANCEMENT] [./scripts]
Closes facebook#17457

Differential Revision: D6673843

Pulled By: shergin

fbshipit-source-id: 65a072c3b79593391f257191b1372e7e9c8799f1
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edcs @facebook-github-bot @pull-bot @turnrye