re #17486 - set _locationManager if auth skipped #17487
Conversation
make sure locationManager is being set before continuing. Used if !locationManager vs else on previous statement as we should NEVER enter this code without _locationManager set. Also the else version might experience issues if someone touches the auth code and doesn't check this case, so seems more "long term stable".
|
@facebook-github-bot label Android Generated by 🚫 dangerJS |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@rigdern - please do lmk if you have any feedback on the change. I thought this was the lowest touch way to address it. |
| @@ -158,6 +158,12 @@ - (void)beginLocationUpdatesWithDesiredAccuracy:(CLLocationAccuracy)desiredAccur | |||
| if (!_locationConfiguration.skipPermissionRequests) { | |||
| [self requestAuthorization]; | |||
| } | |||
|
|
|||
| //re #17486 - If someone skips permissions, location manager is not being set. so lets make sure its set before continuing | |||
There was a problem hiding this comment.
I don't think this comment is necessary. The code is clear enough without it.
removed unnecessary comment - see #17487 (review)
|
@rigdern - my bad! I could swear I tagged you but must have done something wrong. I'll make sure to do that next time. Great! I made the change you suggested as well :) |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@ide is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This fixes #17486
make sure locationManager is being set before continuing.
Used if !locationManager vs else on previous statement as we should NEVER enter this code without _locationManager set. Also the else version might experience issues if someone touches the auth code and doesn't check this case, so seems more "long term stable".
Motivation
This fixes #17486
Test Plan
Related PRs
re #15096
Release Notes
[IOS] [BUGFIX] [GeoLocation] - Fix skipPermissionRequests by setting _locationManager