Make sure refreshControl shows up on initial render if specified #17727
Conversation
facebook-github-bot
added
CLA Signed
Reviewed By: shergin Differential Revision: D6470066 fbshipit-source-id: 44fb03c264d98af61dccfa0146690fd49ee9f2ab
|
Thanks for the fix! @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
@vonovak Could you rebase on master |
|
@janicduplessis I rebased. The CI errors do not seem to be related. |
|
I just ran into this as well and made this snack to repro: https://snack.expo.io/Bkf79Fcrf I'll take a look at why the diff failed to land. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: [this commit](2e1707d) which was just a small refactor broke refreshControl behavior - if we render FlatList with refreshing=true, the refreshControl won't be visible on initial render. The problem is, the [previous beginRefreshing method](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeL51) was renamed to `beginRefreshingProgramatically` and the old call was left in one place [here](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeR47). Now, I am not sure what kind of jumping the mentioned commit was fixing, but since this fix only concerns the initial render, I believe it will not influence the jumping fix. I have tested this locally in my app, can provide a video if needed. none [IOS] [BUGFIX] [RefreshControl] - Make sure refreshControl shows up on initial render if specified Closes #17727 Differential Revision: D6827402 Pulled By: shergin fbshipit-source-id: 25849244e87af54f25d636b6ade7adcf88958980
Summary: [this commit](facebook@2e1707d) which was just a small refactor broke refreshControl behavior - if we render FlatList with refreshing=true, the refreshControl won't be visible on initial render. The problem is, the [previous beginRefreshing method](facebook@2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeL51) was renamed to `beginRefreshingProgramatically` and the old call was left in one place [here](facebook@2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeR47). Now, I am not sure what kind of jumping the mentioned commit was fixing, but since this fix only concerns the initial render, I believe it will not influence the jumping fix. I have tested this locally in my app, can provide a video if needed. none [IOS] [BUGFIX] [RefreshControl] - Make sure refreshControl shows up on initial render if specified Closes facebook#17727 Differential Revision: D6827402 Pulled By: shergin fbshipit-source-id: 25849244e87af54f25d636b6ade7adcf88958980
react-native-bot
removed
the
Import Started
Motivation
this commit which was just a small refactor broke refreshControl behavior - if we render FlatList with refreshing=true, the refreshControl won't be visible on initial render.
The problem is, the previous beginRefreshing method was renamed to
beginRefreshingProgramaticallyand the old call was left in one place here.Now, I am not sure what kind of jumping the mentioned commit was fixing, but since this fix only concerns the initial render, I believe it will not influence the jumping fix.
Test Plan
I have tested this locally in my app, can provide a video if needed.
Related PRs
none
Release Notes
[IOS] [BUGFIX] [RefreshControl] - Make sure refreshControl shows up on initial render if specified