-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gradle and Android SDK versions. #17747
Changes from 5 commits
43fdacc
f37d9a1
c9a392f
c834ecc
99dcddf
a71a55d
f98deb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -242,12 +242,11 @@ task packageReactNdkLibsForBuck(dependsOn: packageReactNdkLibs, type: Copy) { | |||
} | ||||
|
||||
android { | ||||
compileSdkVersion 23 | ||||
buildToolsVersion "23.0.1" | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, we rely on
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new gradle version will choose the build tools version itself, but specifying it here won't (afaik) hurt either. |
||||
compileSdkVersion 27 | ||||
|
||||
defaultConfig { | ||||
minSdkVersion 16 | ||||
targetSdkVersion 22 | ||||
targetSdkVersion 27 | ||||
versionCode 1 | ||||
versionName "1.0" | ||||
|
||||
|
@@ -292,7 +291,7 @@ android { | |||
dependencies { | ||||
compile fileTree(dir: 'src/main/third-party/java/infer-annotations/', include: ['*.jar']) | ||||
compile 'javax.inject:javax.inject:1' | ||||
compile 'com.android.support:appcompat-v7:23.0.1' | ||||
api 'com.android.support:appcompat-v7:27.0.2' | ||||
compile 'com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0' | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. replace compile with implementation |
||||
compile 'com.facebook.fresco:fresco:1.9.0' | ||||
compile 'com.facebook.fresco:imagepipeline-okhttp3:1.9.0' | ||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
package="com.facebook.react.tests.gradle" | ||
android:versionCode="1" | ||
android:versionName="1.0" > | ||
<uses-sdk android:targetSdkVersion="7" /> | ||
<uses-sdk android:targetSdkVersion="27" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is useless. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be completely removed. Also libraries should not even define |
||
<supports-screens android:anyDensity="true" /> | ||
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" /> | ||
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
dependencies { | ||
compile fileTree(dir: "libs", include: ["*.jar"]) | ||
compile "com.android.support:appcompat-v7:23.0.1" | ||
compile "com.facebook.react:react-native:0.18.+" | ||
api fileTree(dir: "libs", include: ["*.jar"]) | ||
api "com.android.support:appcompat-v7:27.0.2" | ||
api "com.facebook.react:react-native:0.18.+" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
dependencies { | ||
compile project(':test') | ||
compile(project(':test2')) { | ||
api project(':test') | ||
api(project(':test2')) { | ||
exclude(group: 'org.unwanted', module: 'test10') | ||
} | ||
compile fileTree(dir: "libs", include: ["*.jar"]) | ||
compile "com.android.support:appcompat-v7:23.0.1" | ||
compile "com.facebook.react:react-native:0.18.+" | ||
api fileTree(dir: "libs", include: ["*.jar"]) | ||
api "com.android.support:appcompat-v7:27.0.2" | ||
api "com.facebook.react:react-native:0.18.+" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 We're using 27.0.2 internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know.