Support non-integer modulus in ModulusAnimatedNode on Android #17860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Attention: @janicduplessis Generated by 🚫 dangerJS |
janicduplessis
approved these changes
Feb 7, 2018
|
Thanks for fixing this! @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
For future reference native animated tests are located here but sadly there isn't one for the modulo node. It should be possible to add one that's similar to the addition / multiplication ones, if you ever feel like writing android tests 🙂. |
Plo4ox
pushed a commit
to Plo4ox/react-native
that referenced
this pull request
Feb 17, 2018
Summary: `Animated.modulo(value, modulus)` supports a non-integer modulus in the iOS and JS implementations but crashes on Android when `useNativeDriver` is set to `true`. Unfortunately, I'm not fluent enough with this codebase to add a Java test for this fix - especially as I couldn't find any analogous tests to extrapolate from. However, the fix itself seems straightforward enough. None needed [ANDROID] [BUGFIX] [Animated] - Support non-integer modulus in .modulo() Closes facebook#17860 Differential Revision: D6918799 Pulled By: hramos fbshipit-source-id: 8d15e4bc881ed41a4123c6f811c0c72119f67be0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Animated.modulo(value, modulus)supports a non-integer modulus in the iOS and JS implementations but crashes on Android whenuseNativeDriveris set totrue.Test Plan
Unfortunately, I'm not fluent enough with this codebase to add a Java test for this fix - especially as I couldn't find any analogous tests to extrapolate from. However, the fix itself seems straightforward enough.
Related PRs
None needed
Release Notes
[ANDROID] [BUGFIX] [Animated] - Support non-integer modulus in .modulo()