Update node-notifier (has mem leak fix) #18033
Conversation
facebook-github-bot
added
CLA Signed
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
@hramos thanks for the review! Looks like the android test timed-out - could you retry it? |
Motivation
Noticed that we're on a version of node-notifier that has a leak mentioned here and fixed in the newest version.
Test plan
Automated tests
Release Notes
[INTERNAL] [BUGFIX] [package.json] - Update node-notifier dependency