Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Platform check from WebSocket module #18056

Closed
wants to merge 2 commits into from
Closed

Remove Platform check from WebSocket module #18056

wants to merge 2 commits into from

Commits on Feb 22, 2018

  1. Remove Platform check from WebSocket module 

    WebSocket uses the Platform module to check how many arguments for the `close` method should be used. In react-native-windows, we have the same number of arguments for `close` as Android, so we're prevented from using this module as-is because of the platform check (see https://github.com/Microsoft/react-native-windows/blob/master/Libraries/WebSocket/WebSocket.windows.js#L136).

By switching to an argument count check, this module becomes more useful cross-platform. If you'd like to keep the platform check, I'm also open to inverting the conditional, e.g., `if (Platform.OS !== 'ios')`.
    @rozele
    rozele committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    86d9891 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Minor change to argument count conditional.

    @rozele
    rozele committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    f9961c0 View commit details
    Browse the repository at this point in the history