-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inverted prop in SectionListExample #18370
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 14, 2018
react-native-bot
added
Feature Request 🌟
Ran Commands
One of our bots successfully processed a command.
labels
Mar 16, 2018
Looks good, thanks! @facebook-github-bot shipit |
Something went wrong executing that command, @hramos could you take a look? |
facebook-github-bot
added
the
Import Started
This pull request has been imported. This does not imply the PR has been approved.
label
Mar 18, 2018
facebook-github-bot
approved these changes
Mar 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@janicduplessis Thanks 👍 |
hramos
added
Type: Enhancement
A new feature or enhancement of an existing feature.
and removed
🌟Feature Request
labels
Mar 19, 2018
hamaron
pushed a commit
to hamaron/react-native
that referenced
this pull request
Apr 9, 2018
Summary: This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample. Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not. [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample Closes facebook#18370 Differential Revision: D7317168 Pulled By: hramos fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
campsafari
pushed a commit
to exozet/react-native
that referenced
this pull request
Apr 11, 2018
Summary: This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample. Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not. [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample Closes facebook#18370 Differential Revision: D7317168 Pulled By: hramos fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample. Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not. [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample Closes facebook#18370 Differential Revision: D7317168 Pulled By: hramos fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample. Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not. [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample Closes facebook#18370 Differential Revision: D7317168 Pulled By: hramos fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
bunnyc1986
pushed a commit
to bunnyc1986/react-native
that referenced
this pull request
May 11, 2018
Summary: This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample. Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not. [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample Closes facebook#18370 Differential Revision: D7317168 Pulled By: hramos fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample. Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not. [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample Closes facebook#18370 Differential Revision: D7317168 Pulled By: hramos fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
Summary: This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample. Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not. [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample Closes facebook/react-native#18370 Differential Revision: D7317168 Pulled By: hramos fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Import Started
This pull request has been imported. This does not imply the PR has been approved.
Ran Commands
One of our bots successfully processed a command.
Type: Enhancement
A new feature or enhancement of an existing feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds an option to pass
inverted
prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample.Test Plan
Run RNTester app on device or simulator and select SectionListExample. Depending on switching
inverted
option, you can see either inverted list or not.Release Notes
[GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample