Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][WebSocket] use correct delegate queue in RCTRSWebSocket #18530

Closed
wants to merge 2 commits into from
Closed

[iOS][WebSocket] use correct delegate queue in RCTRSWebSocket #18530

wants to merge 2 commits into from

Commits on Mar 23, 2018

  1. websocket / use correct delegate queue in RCTRSWebSocket 

    This commit makes the websocket's delegate dispatch queue use RCTWebSocketModule's method queue. 

This fixes a bug where didReceiveMessage was called on the wrong queue, which is especially harmful if the websocket has a contentHandler expects to be running on the RCTWebSocketModule's method queue.
    @jhgg
    jhgg authored Mar 23, 2018
    Configuration menu
    Copy the full SHA
    3aa6a92 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2018

  1. Update RCTWebSocketModule.m

    @jhgg
    jhgg authored Mar 24, 2018
    Configuration menu
    Copy the full SHA
    ade9e8d View commit details
    Browse the repository at this point in the history