Android: include error types in getCurrentPosition error #18533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on Android, when error occurs in getCurrentPosition of Geolocation then there are no error types in the error, while iOS error includes error types. This patch provides feature parity with iOS.e
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
react-native-bot
added
the
Missing Changelog
Generated by 🚫 dangerJS |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Mar 26, 2018
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hamaron
pushed a commit
to hamaron/react-native
that referenced
this pull request
Apr 9, 2018
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. Include geolocation error types in error, and provide feature parity with iOS. If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value. This is minor fix that provides feature parity with iOS. Closes facebook#18533 Differential Revision: D7396586 Pulled By: mdvacca fbshipit-source-id: bd698b80a3d075456738a3d4e48b572ae819ee3d
campsafari
pushed a commit
to exozet/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. Include geolocation error types in error, and provide feature parity with iOS. If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value. This is minor fix that provides feature parity with iOS. Closes facebook#18533 Differential Revision: D7396586 Pulled By: mdvacca fbshipit-source-id: bd698b80a3d075456738a3d4e48b572ae819ee3d
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. Include geolocation error types in error, and provide feature parity with iOS. If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value. This is minor fix that provides feature parity with iOS. Closes facebook#18533 Differential Revision: D7396586 Pulled By: mdvacca fbshipit-source-id: bd698b80a3d075456738a3d4e48b572ae819ee3d
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. Include geolocation error types in error, and provide feature parity with iOS. If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value. This is minor fix that provides feature parity with iOS. Closes facebook#18533 Differential Revision: D7396586 Pulled By: mdvacca fbshipit-source-id: bd698b80a3d075456738a3d4e48b572ae819ee3d
bunnyc1986
pushed a commit
to bunnyc1986/react-native
that referenced
this pull request
May 11, 2018
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. Include geolocation error types in error, and provide feature parity with iOS. If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value. This is minor fix that provides feature parity with iOS. Closes facebook#18533 Differential Revision: D7396586 Pulled By: mdvacca fbshipit-source-id: bd698b80a3d075456738a3d4e48b572ae819ee3d
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. Include geolocation error types in error, and provide feature parity with iOS. If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value. This is minor fix that provides feature parity with iOS. Closes facebook#18533 Differential Revision: D7396586 Pulled By: mdvacca fbshipit-source-id: bd698b80a3d075456738a3d4e48b572ae819ee3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
Include geolocation error types in error, and provide feature parity with iOS.
Test Plan
If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value.
Release Notes
This is minor fix that provides feature parity with iOS.