Native Animated - Support border radius #18574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Mar 27, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hamaron
pushed a commit
to hamaron/react-native
that referenced
this pull request
Apr 9, 2018
Summary: Border radius already works properly with native animated but was not in the whitelisted props. Tested in an app that animating border radius with native animated actually works. [GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius Closes facebook#18574 Differential Revision: D7415956 Pulled By: hramos fbshipit-source-id: 6dd46bcdcb10c6a1956dd1f526212f33a4f44425
campsafari
pushed a commit
to exozet/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Border radius already works properly with native animated but was not in the whitelisted props. Tested in an app that animating border radius with native animated actually works. [GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius Closes facebook#18574 Differential Revision: D7415956 Pulled By: hramos fbshipit-source-id: 6dd46bcdcb10c6a1956dd1f526212f33a4f44425
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Border radius already works properly with native animated but was not in the whitelisted props. Tested in an app that animating border radius with native animated actually works. [GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius Closes facebook#18574 Differential Revision: D7415956 Pulled By: hramos fbshipit-source-id: 6dd46bcdcb10c6a1956dd1f526212f33a4f44425
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Border radius already works properly with native animated but was not in the whitelisted props. Tested in an app that animating border radius with native animated actually works. [GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius Closes facebook#18574 Differential Revision: D7415956 Pulled By: hramos fbshipit-source-id: 6dd46bcdcb10c6a1956dd1f526212f33a4f44425
bunnyc1986
pushed a commit
to bunnyc1986/react-native
that referenced
this pull request
May 11, 2018
Summary: Border radius already works properly with native animated but was not in the whitelisted props. Tested in an app that animating border radius with native animated actually works. [GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius Closes facebook#18574 Differential Revision: D7415956 Pulled By: hramos fbshipit-source-id: 6dd46bcdcb10c6a1956dd1f526212f33a4f44425
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Border radius already works properly with native animated but was not in the whitelisted props. Tested in an app that animating border radius with native animated actually works. [GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius Closes facebook#18574 Differential Revision: D7415956 Pulled By: hramos fbshipit-source-id: 6dd46bcdcb10c6a1956dd1f526212f33a4f44425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Border radius already works properly with native animated but was not in the whitelisted props.
Test Plan
Tested in an app that animating border radius with native animated actually works.
Release Notes
[GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius