<Text> module add textDecoration style attributes #1869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
looks like the examples need to be re-recorded, justasec... |
pcottle
force-pushed
the
squashRebaseKJRemote
branch
from
6507d52
to
6f240db
Compare
|
Re-recorded tests, new image and results:
|
|
Thanks @pcottle! This looks good to me |
|
It would be great to get this in for 0.8.0-rc if it's ready, we are planning on shipping that sometime in the new couple of days if possible @nicklockwood (#1864) |
|
Should be OK - I'll just need to check there are no issues with Android compatibility since it's a shared component. |
aleclarson
pushed a commit
to aleclarson/react-native
that referenced
this pull request
Sep 20, 2015
Summary: This is simply a rebased and squashed version of @KJlmfe's PR over at facebook#845 It was actually already squashed into one commit, but for some reason that was hard to see from the original PR. Closes facebook#1869 Github Author: KJlmfe <kjlmfe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply a rebased and squashed version of @KJlmfe's PR over at #845
It was actually already squashed into one commit, but for some reason that was hard to see from the original PR.