Make KeyboardAvoidingView with behavior="height" resize on keyboard close

[WaldoJeffers]

Fixes #13754

Test Plan

The bug was present because flex: 0 was applied even if the keyboard was closed (ie this.state.bottom === 0), and also because the initial frame height was never saved. On every render, the code used the current frame height, which was incorrect because the keyboard height is subtracted each time.
Also removed a weird componentWillUpdate which mutated the next state.

Before

After

Related PRs

This PR does not require a documentation as it fixes a bug. It's related to #16965, but goes further. Credits to @shauns for the initial commit, and thanks to @MatthieuLemoine for his help!

Release Notes

[ANDROID] [BUGFIX] [KeyboardAvoidingView] - Make KeyboardAvoidingView resize back on keyboard close
[IOS] [BUGFIX] [KeyboardAvoidingView] - Make KeyboardAvoidingView resize back on keyboard close

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

@WaldoJeffers I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[dNitro]

@hramos , this PR needs reviewer. Issue still presents on latest versions ( 0.55.4 ).

[WaldoJeffers]

Yep, would appreciate some reviewers, but didn't know whom to ping :/

[hramos]

Looking at the blame/history information for the files touched by the PR is a good way to find people that could review your PR.

[hramos]

Can you fix the unresolved conflict? Also make sure all tests are passing. Perhaps you just need to rebase, but we can't merge this while tests are red.

[raphaelrk]

Would be great to have this fix in, our app has UI's that don't scale back to their full size after the keyboard closes and I assume this would fix it

[WaldoJeffers]

Will try to resolve the conflicts today :)

[WaldoJeffers]

@raphaelrk @hramos I merged & fixed all tests but one, I'm having trouble figuring out what's wrong :/

[hramos]

CocoaPods failure is unrelated. Tests look good.

[WaldoJeffers]

Maybe @nicklockwood could help with the review?

[bcalik]

So why this is not merged yet?

[hramos]

@bcalik it has not been merged because it has not been reviewed. I myself am not comfortable reviewing this area of the code, otherwise I'd jump in.

[WaldoJeffers]

@hramos Isn't there a better system to find people who might be able to review this one?

I tried to look into these files' history and pinged someone, but from the outside of the React Native team, it's frankly very hard to say who's in the team, who's still active, who will answer you. It's quite frustrating to dedicate some time contributing, knowing that you have absolutely no idea if there's a probability to find a reviewer and to see your PR merged.

If you're not familiar with this code, do you know who would be more familiar with it, even if it's not the person who will do the review in the end?

[hramos]

If the people who've worked on the file before haven't responded, I'd look through the recent PRs that have been merged and see if any of the people who reviewed them can take a look.

The issue you raised is one we see within the team as well - we're a small team and there's components like this one where there is no clear owner. Typically, if there's a bug affecting one of our products, the person affected will take ownership of shipping the fix as they're in the best position to validate the fix.

We'd like to get to a point where we can process more of these contributions and get feedback back as fast as possible, but we're not there yet.

[facebook-github-bot]

@PeteTheHeat is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[PeteTheHeat]

This change seems very reasonable to me, merging.

[facebook-github-bot]

@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @WaldoJeffers in 3711ea6.

^{When will my fix make it into a release? | Upcoming Releases}