Android subpixel text #19043
Closed
Android subpixel text #19043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@kevinresol I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
no idea. but maybe @mdvacca? I see him reviewed some PR in the folder |
|
@mkonicek I see you were the original implementer. Could you give us some comment on this? |
|
What can I do to get this reviewed? |
|
or @andreicoman11 ? As I see you reviewed bfeaa6a |
|
@mkonicek @mdvacca @andreicoman11 can even anyone point me to a direction? |
|
@mkonicek @mdvacca @andreicoman11 could you please at least point me to some possibly responsible persons? |
1 similar comment
|
@pasqualeanatriello any idea I could get this reviewed? |
|
@hramos sorry to bother but I would like to have someone from facebook to review this, or can you at least give me some directions? |
|
Hey Kevin sorry no one of the people you tagged have replied here - I'll try to find someone who can review this, since it's a one-line change I feel it would be a good-to-have in next releases 🤗 (sadly I can't re-run tests, can you rebase your commit to trigger a new one?) EDIT: the flag https://developer.android.com/reference/android/graphics/Paint#setSubpixelText(boolean) |
kevinresol
force-pushed
the
android_subpixel_text
branch
from
317e100 to
e5b6965
Compare
|
Updated. |
|
Looks like the errors in CI are not related to your commit, let's try to merge it :) |
kelset
approved these changes
Sep 24, 2018
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
kelset is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@kevinresol merged commit 65e4e67 into Once this commit is added to a release, you will see the corresponding version tag below the description at 65e4e67. If the commit has a single |
grabbou
pushed a commit
that referenced
this pull request
Oct 2, 2018
Summary: <!-- Required: Write your motivation here. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. --> Fixes inconsistency in custom font rendering in android. See explanation below. <!-- Required: Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! --> I tested the following on my physical device (Sony Z5C) and on Android emulator on Mac. The test app contains various fonts in the AvenirNext family, which are added to the app as `.ttf` format. Note that the character "thickness" is inconsistent. Some characters looks thicker than other. See the screenshots below as an example: - Looks thicker: right half of the `g` and `&` as in "Region & Language" (list-view screen) - Looks thicker: `w` as in `Change Password` (list-view screen) - Looks vertically compressed: `a` and `e` as in "Message" in the bottom bar (list-view screen) - Looks thicker: `A`, `N`, `V`, `v` (paragraph screen) - Looks thinner: `i` (paragraph screen), it leaves extra space on its right hand side   Every characters has consistent "weight" and looks nice:   <!-- Does this PR require a documentation change? Create a PR at https://github.com/facebook/react-native-website and add a link to it here. --> None <!-- Required. Help reviewers and the release process by writing your own release notes. See below for an example. --> [ANDROID] [ENHANCEMENT] [CustomStyleSpan] - Enable subpixel text rendering <!-- **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [ {Component} ] [ INTERNAL ] [ ENHANCEMENT ] [ {Filename} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Pull Request resolved: #19043 Differential Revision: D10008155 Pulled By: hramos fbshipit-source-id: 7fe9bb0f9be80380947ff80eac522e3cfd6b22cf
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: <!-- Required: Write your motivation here. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. --> Fixes inconsistency in custom font rendering in android. See explanation below. <!-- Required: Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! --> I tested the following on my physical device (Sony Z5C) and on Android emulator on Mac. The test app contains various fonts in the AvenirNext family, which are added to the app as `.ttf` format. Note that the character "thickness" is inconsistent. Some characters looks thicker than other. See the screenshots below as an example: - Looks thicker: right half of the `g` and `&` as in "Region & Language" (list-view screen) - Looks thicker: `w` as in `Change Password` (list-view screen) - Looks vertically compressed: `a` and `e` as in "Message" in the bottom bar (list-view screen) - Looks thicker: `A`, `N`, `V`, `v` (paragraph screen) - Looks thinner: `i` (paragraph screen), it leaves extra space on its right hand side   Every characters has consistent "weight" and looks nice:   <!-- Does this PR require a documentation change? Create a PR at https://github.com/facebook/react-native-website and add a link to it here. --> None <!-- Required. Help reviewers and the release process by writing your own release notes. See below for an example. --> [ANDROID] [ENHANCEMENT] [CustomStyleSpan] - Enable subpixel text rendering <!-- **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [ {Component} ] [ INTERNAL ] [ ENHANCEMENT ] [ {Filename} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Pull Request resolved: facebook#19043 Differential Revision: D10008155 Pulled By: hramos fbshipit-source-id: 7fe9bb0f9be80380947ff80eac522e3cfd6b22cf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inconsistency in custom font rendering in android. See explanation below.
Test Plan
I tested the following on my physical device (Sony Z5C) and on Android emulator on Mac.
The test app contains various fonts in the AvenirNext family, which are added to the app as
.ttfformat.Before:
Note that the character "thickness" is inconsistent. Some characters looks thicker than other. See the screenshots below as an example:
gand&as in "Region & Language" (list-view screen)was inChange Password(list-view screen)aandeas in "Message" in the bottom bar (list-view screen)A,N,V,v(paragraph screen)i(paragraph screen), it leaves extra space on its right hand sideAfter:
Every characters has consistent "weight" and looks nice:
Related PRs
None
Release Notes
[ANDROID] [ENHANCEMENT] [CustomStyleSpan] - Enable subpixel text rendering