DialogModule crash fixes. #19332
DialogModule crash fixes. #19332
Conversation
facebook-github-bot
added
the
CLA Signed
dryganets
force-pushed
the
sergeyd/dialog-module-fix
branch
from
16ce65e to
c4a4c20
Compare
|
@dryganets I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
dryganets
force-pushed
the
sergeyd/dialog-module-fix
branch
from
c4a4c20 to
932d92c
Compare
|
@dryganets I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
@dryganets hey, I'm facing these crashes in a DialogModule on React Native v57. We didn't had this addressed yet in the latest RN version, aren't we? Shall we update this PR and merge it? |
dryganets
force-pushed
the
sergeyd/dialog-module-fix
branch
from
932d92c to
ddd10f3
Compare
Generated by 🚫 dangerJS |
|
@webdevbyjoss, I updated the PR. It fixes the problem for us. @hramos, could you take a look? |
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dryganets merged commit 9df892c into |
elicwhite
added
p: Microsoft
I'm trying to fix DialogModule crashes we have in production: #6228
In this PR I'm fixing the following problem:
The fragment manager methods should be called only from the foreground. Now dismissExisting is protected by the mIsForeground variable as well as showNewAlert method.
Test Plan
Make sure that dialogs work after this change.
Release Notes
[ANDROID] [BUGFIX] [DialogModule] - Race condition in dialog module fixed.