Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing link to Android build guide. #19450

Closed

Conversation

kneth
Copy link
Contributor

@kneth kneth commented May 25, 2018

While browsing the repository, I noticed that the link to how to build for Android has changed. It's a very simple fix.

Test Plan

Verifying that the URL is correct.

Related PRs

None.

Release Notes

[DOCS] [BUGFIX] [ReactAndroid/README.md] - Incorrect URL

@kneth kneth requested a review from hramos as a code owner May 25, 2018 20:18
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2018
@react-native-bot react-native-bot added ✅Test Plan Type: Docs Issues concerning the docs are tracked elsewhere: https://github.com/facebook/react-native-website Platform: Android Android applications. labels May 25, 2018
@chirag04
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label May 27, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirag04 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

macdoum1 pushed a commit to macdoum1/react-native that referenced this pull request Jun 28, 2018
Summary:
While browsing the repository, I noticed that the link to how to build for Android has changed. It's a very simple fix.

Verifying that the URL is correct.

None.

<!--
  Required.
  Help reviewers and the release process by writing your own release notes. See below for an example.
-->

[DOCS] [BUGFIX] [ReactAndroid/README.md] - Incorrect URL
Closes facebook#19450

Differential Revision: D8178077

Pulled By: hramos

fbshipit-source-id: 388c35b5322416333681d66ef1b8ca42e9e83151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. Platform: Android Android applications. Type: Docs Issues concerning the docs are tracked elsewhere: https://github.com/facebook/react-native-website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants