Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][VirtualizedList] Fix scroll over bottom with scrollToIndex #19970

Closed
wants to merge 1 commit into from
Closed

Conversation

manse
Copy link

@manse manse commented Jun 29, 2018

Fixes #13594

Test Plan:

This example shows that the behavior scrollToIndex of VirtualizedList (FlatList) differs between Android and iOS.
The behavior of Android is accurate, while on iOS it scrolls over bottom.
Over scrolled VirtualizedList jumps to a different location with a little scroll.

Verify the problem and issue #13594, tested this fix worked.

Problem

Expected Behavior (this PR)

Android

There is no problem on Android. It is probably corrected by the OS.

Release Notes:

[IOS][BUGFIX][VirtualizedList] - Scroll over bottom with scrollToIndex in iOS

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@manse manse changed the title [iOS][VirtualizedList] Fix scroll over bottom in scrollToIndex [iOS][VirtualizedList] Fix scroll over bottom with scrollToIndex Jun 29, 2018
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 29, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@manse I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@keldorus
Copy link

Can we have some reviewers over here ?

@adamnator92
Copy link

Any reviewers can merge this issues?

@Thioby
Copy link

Thioby commented Jan 17, 2019

Still open?

@hramos hramos removed the 🔶Lists label Jan 25, 2019
@berickson1
Copy link
Contributor

There's a similar PR posted to address this at the ScrollView itself
#22769

If that's accepted by FB, this change may not be needed

@manse manse closed this Feb 12, 2019
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2019
Summary:
Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue.

Fixes like #13594 #22768 #19970 .

[iOS] [Fixed] - Fixed scrollView offset out of content size.
Pull Request resolved: #23427

Differential Revision: D14162663

Pulled By: cpojer

fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
mbardauskas pushed a commit to mbardauskas/react-native that referenced this pull request Feb 21, 2019
Summary:
Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue.

Fixes like facebook#13594 facebook#22768 facebook#19970 .

[iOS] [Fixed] - Fixed scrollView offset out of content size.
Pull Request resolved: facebook#23427

Differential Revision: D14162663

Pulled By: cpojer

fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
grabbou pushed a commit that referenced this pull request Mar 22, 2019
Summary:
Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue.

Fixes like #13594 #22768 #19970 .

[iOS] [Fixed] - Fixed scrollView offset out of content size.
Pull Request resolved: #23427

Differential Revision: D14162663

Pulled By: cpojer

fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FlatList] scrollToIndex will scroll over bottom
8 participants