[iOS][VirtualizedList] Fix scroll over bottom with scrollToIndex #19970
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
manse
changed the title
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@manse I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
Can we have some reviewers over here ? |
|
Any reviewers can merge this issues? |
|
Still open? |
|
There's a similar PR posted to address this at the ScrollView itself If that's accepted by FB, this change may not be needed |
Summary: Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue. Fixes like #13594 #22768 #19970 . [iOS] [Fixed] - Fixed scrollView offset out of content size. Pull Request resolved: #23427 Differential Revision: D14162663 Pulled By: cpojer fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
Summary: Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue. Fixes like facebook#13594 facebook#22768 facebook#19970 . [iOS] [Fixed] - Fixed scrollView offset out of content size. Pull Request resolved: facebook#23427 Differential Revision: D14162663 Pulled By: cpojer fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
Summary: Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue. Fixes like #13594 #22768 #19970 . [iOS] [Fixed] - Fixed scrollView offset out of content size. Pull Request resolved: #23427 Differential Revision: D14162663 Pulled By: cpojer fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
Fixes #13594
Test Plan:
This example shows that the behavior
scrollToIndexofVirtualizedList(FlatList) differs between Android and iOS.The behavior of Android is accurate, while on iOS it scrolls over bottom.
Over scrolled VirtualizedList jumps to a different location with a little scroll.
Verify the problem and issue #13594, tested this fix worked.
Problem
Expected Behavior (this PR)
Android
There is no problem on Android. It is probably corrected by the OS.
Release Notes:
[IOS][BUGFIX][VirtualizedList] - Scroll over bottom with scrollToIndex in iOS