Bump Android SDK to 28

[dulmandakh]

This PR will bump Android SDK to 28, build tools to 28.0.2 and support library to 27.1.1. But issue related to aapt2 is breaking RNTester app.

Solution

After some research I found that we need to compile (or copy) resources using aapt2 compile command. aapt2 is located in ${sdkDir}/${buildToolsVersion} directory.

And resource bundling is handled in copy function of the local-cli/bundle/saveAssets.js file. In react.gradle file we can access sdkDir via project.android.sdkDirectory, buildToolsVersion via project.android.sdkDirectory.

The solution might be pass aapt2 path to bundler and use it to compile resources.

I'm not proficient in gradle, and would like to discuss to find better solution.

Please help @gengjiawen @hramos @kelset

Resources

• https://android.googlesource.com/platform/frameworks/base/+/master/tools/aapt2/readme.md
• https://stackoverflow.com/questions/42082352/how-to-use-aapt2-where-is-the-documentation

Test Plan:

Everything should build and run as usual.

Release Notes:

[ANDROID] [ENHANCEMENT] [SDK] - Bump to 27

[dulmandakh]

There is no major or breaking change in 27, as it carries Oreo codename and 8.1 version number.

Once merged I would like to focus more on NDK and JSC part.

[gengjiawen]

Aapt2 through path is not the right way.
I am looking into gradle dsl to find the related api. But I am not expert too. Any chance you know something we can hook @janicduplessis ?

[AndrewJack]

@CFKevinRef updated the gradle file to work with Android gradle plugin v3, but it was reverted.

Commit: d16ff3b
revert: 3f8a04b

Gradle v3 file: https://github.com/facebook/react-native/blob/d16ff3bd8b92fa84a9007bf5ebedd8153e4c089d/react.gradle

try adding that back in?

[gengjiawen]

Maybe not adding it back, since it's not a clean fix. We need aapt2 to support instant run.

[MarkOSullivan94]

@gengjiawen do we need to support instant run? If not, could we not disable AAPT2 for now?

If you are experiencing issues while using AAPT2, you can disable it by setting android.enableAapt2=false in your gradle.properties file and restarting the Gradle daemon by running ./gradlew --stop from the command line.

Source: https://developer.android.com/studio/build/gradle-plugin-3-0-0

If we don't need to support it, I don't see why we couldn't do what @AndrewJack suggested and add that commit back in.

[gengjiawen]

This is some snippet in AaptV2CommandBuilder, maybe related. But I have find the method we can get the aapt2 path.

    public static ImmutableList<String> makeCompile(@NonNull CompileResourceRequest request) {
        ImmutableList.Builder<String> parameters = new ImmutableList.Builder<>();

        if (request.isPseudoLocalize()) {
            parameters.add("--pseudo-localize");
        }

        if (!request.isPngCrunching()) {
            // Only pass --no-crunch for png files and not for 9-patch files as that breaks them.
            String lowerName = request.getInputFile().getPath().toLowerCase(Locale.US);
            if (lowerName.endsWith(SdkConstants.DOT_PNG)
                    && !lowerName.endsWith(SdkConstants.DOT_9PNG)) {
                parameters.add("--no-crunch");
            }
        }

        parameters.add("--legacy");
        parameters.add("-o", request.getOutputDirectory().getAbsolutePath());
        parameters.add(request.getInputFile().getAbsolutePath());

        return parameters.build();
    }

[gengjiawen]

The commit doesn't handle aapt2. If you disable aapt2, current code works fine.

[kelset]

Side-related to appt2 (and reason why I think we should care/have aapt2 support): #16906 (and by extension react-navigation/react-navigation#3097)

[AndrewJack]

Could keep both scripts in react native, if there's a concern that it'll break a lot of builds.
react.gradle &react-v3.gradle

We are currently using the linked gradle script with aapt2 enabled.

Additionally the current react.gradle script doesn't work with Android Gradle plugin 3.1.3 anyway, aapt2 enabled or not.

[dulmandakh]

Also App Bundling is not working when android.enableAapt2=false, and we need to fix the issue.

[facebook-github-bot]

@dulmandakh I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[jwaldrip]

Any update here?

[gengjiawen]

With #20526 get merged, @dulmandakh Let's rebase code and test again ?

[gengjiawen]

nope, all has better IDE support.

[dulmandakh]

Bumped Android SDK to 28, which was released just yesterday. We still use Support Library 27.x because 28.x is not stable yet.

[gengjiawen]

I mean most of them, like okhttp, fresco, appcompat. And also the compile is still exist.

[gengjiawen]

Maybe 3.1.4.

[dulmandakh]

IIRC, 3.1.3 is the latest version.

[gengjiawen]

Nope, 3.1.4. It's out today.

[dulmandakh]

@gengjiawen done, thanks 👍

[dulmandakh]

Android CI was green before Appveyor change requested by @gengjiawen, and it's broken due to issue on Circle CI.

[gengjiawen]

If you change it to api or implementation, what's the error ?

[gengjiawen]

jsc has problem of building using api ?

[gengjiawen]

maybe change the title ?

[dulmandakh]

Closing this PR, because I decided to break it into smaller and easy to review PRs.