Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TextLayoutBuilder from ReactAndroid dependency #20600

Closed
wants to merge 4 commits into from
Closed

Remove TextLayoutBuilder from ReactAndroid dependency #20600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3edbf69
remove textlayoutbuilder from dependency
dulmandakh Aug 8, 2018
8d8c864
Merge branch 'master' into bump-textlayoutbuilder
dulmandakh Aug 8, 2018
8064d27
merge master
dulmandakh Aug 8, 2018
8363ee5
Merge branch 'master' into bump-textlayoutbuilder
dulmandakh Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ReactAndroid/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ dependencies {
compile fileTree(dir: 'src/main/third-party/java/infer-annotations/', include: ['*.jar'])
compile 'javax.inject:javax.inject:1'
compile 'com.android.support:appcompat-v7:26.1.0'
compile 'com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0'
compile "com.facebook.fresco:fresco:${FRESCO_VERSION}"
compile "com.facebook.fresco:imagepipeline-okhttp3:${FRESCO_VERSION}"
compile 'com.facebook.soloader:soloader:0.5.1'
Expand Down
4 changes: 0 additions & 4 deletions ReactAndroid/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@
-dontwarn com.facebook.react.**
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }

# TextLayoutBuilder uses a non-public Android constructor within StaticLayout.
# See libs/proxy/src/main/java/com/facebook/fbui/textlayoutbuilder/proxy for details.
-dontwarn android.text.StaticLayout

# okhttp

-keepattributes Signature
Expand Down
34 changes: 0 additions & 34 deletions ReactAndroid/src/main/libraries/textlayoutbuilder/BUCK
View file
Open in desktop

This file was deleted.