Do not override metro.config.js settings
#20705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native.
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Core Team
Missing Changelog
kelset
added
the
Tech: Bundler 📦
rozele
added a commit
to rozele/react-native-dom
that referenced
this pull request
Aug 17, 2018
Moving `hasteImplModulePath` into `resolver` config. This combined with facebook/react-native#20705 will resolve issues for RN 0.57.
This was referenced Aug 17, 2018
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Aug 18, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @rozele in c5297c7. Once this commit is added to a release, you will see the corresponding version tag below the description at c5297c7. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Aug 22, 2018
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: #20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
aleclarson
pushed a commit
to aleclarson/react-native
that referenced
this pull request
Sep 16, 2018
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: facebook#20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: facebook/react-native#20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: React Native overrides the `metro.config.js` settings for, e.g., `hasteImplModulePath`, which prevents us from adding a `metro.config.js` file to the repo for `react-native-windows` to allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a `metro.config.js` file, those settings are not overwritten by React Native. Pull Request resolved: facebook#20705 Differential Revision: D9390146 Pulled By: hramos fbshipit-source-id: 5ccc137490410ace72d7b0e68f2bafcbb233c59f
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native overrides the
metro.config.jssettings for, e.g.,hasteImplModulePath, which prevents us from adding ametro.config.jsfile to the repo forreact-native-windowsto allow us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has ametro.config.jsfile, those settings are not overwritten by React Native.Test Plan:
Run
npm test, also confirmed that this change allows me to set a differenthasteImplModulePathforreact-native-windows.Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CATEGORY] [TYPE] [LOCATION] - Message
[GENERAL][CLI][local-cli/core/index.js] - Do not override
metro.config.jssettings