Apply --reset-cache argument to bundle command
#20706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro. Fixes #20703
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Core Team
Missing Changelog
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Aug 17, 2018
Summary: When the `resetCache` option is set on the bundler, it should also be passed to the `DependencyGraph` and `jest-haste-map` to clean up any cached files there. <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. --> **Summary** <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> While trying to get `react-native-windows` working against the `react-native@0.57` RC, I ran into a series of issues because the `jest-haste-map` cache was not cleaned up when the `--reset-cache` flag was set on the `react-native` CLI. Not only was the option not being passed to `metro` (see facebook/react-native#20706), but `metro` was not passing the `resetCache` option to the `DependencyGraph` and `jest-haste-map`. **Test plan** <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. --> 1. yarn test 2. Validated in `react-native-windows`, where the problem was occurring. I had a case where if my `hasteImpl` implementation from `metro.config.js` had a bug. Even after fixing the bug, the `jest-haste-map` was cached with missing haste modules. Only after deleting that file could I get back to a state where the fixed `metro.config.js` would work. After making this change, using `--reset-cache` from the `react-native` CLI could clear the haste map cache. Pull Request resolved: #223 Differential Revision: D9377632 Pulled By: rafeca fbshipit-source-id: e67b5eeb84937daedc7e9f7b5a7d93e11e0d7edb
|
Looks like we need to wait for Metro to cut a new release that includes facebook/metro@387d487 before landing this. |
hramos
approved these changes
Aug 18, 2018
|
@hramos - there is nothing blocking this from being merged. This change will still fix an issue where |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @rozele in 7062e5b. Once this commit is added to a release, you will see the corresponding version tag below the description at 7062e5b. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Aug 22, 2018
Summary: The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro. Fixes #20703 Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: #20706 Differential Revision: D9400548 Pulled By: hramos fbshipit-source-id: 2c7ed0226cfcdffa8cc77506500c314552baef3f
aleclarson
pushed a commit
to aleclarson/react-native
that referenced
this pull request
Sep 16, 2018
Summary: The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro. Fixes facebook#20703 Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook#20706 Differential Revision: D9400548 Pulled By: hramos fbshipit-source-id: 2c7ed0226cfcdffa8cc77506500c314552baef3f
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro. Fixes #20703 Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook/react-native#20706 Differential Revision: D9400548 Pulled By: hramos fbshipit-source-id: 2c7ed0226cfcdffa8cc77506500c314552baef3f
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro. Fixes facebook#20703 Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook#20706 Differential Revision: D9400548 Pulled By: hramos fbshipit-source-id: 2c7ed0226cfcdffa8cc77506500c314552baef3f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--reset-cacheargument was not working correctly with thebundlecommand. This ensures the--reset-cachearg is passed to metro.Fixes #20703
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Test Plan:
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
react-nativein a node_modules folder of a test app.--reset-cacheargRelease Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CATEGORY] [TYPE] [LOCATION] - Message
[GENERAL][CLI][local-cli/bundle/buildBundle.js] - Apply
--reset-cacheargument tobundlecommand