Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx Android CI #20901

Closed
wants to merge 1 commit into from
Closed

FIx Android CI #20901

wants to merge 1 commit into from

Conversation

dulmandakh
Copy link
Contributor

This PR fixes Android CI

Test Plan:

Android CI is green again

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2018
@dulmandakh dulmandakh requested a review from hramos August 29, 2018 11:29
@react-native-bot react-native-bot added Platform: Android Android applications. ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Aug 29, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 30, 2018
facebook-github-bot
facebook-github-bot approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Salakar
Copy link
Contributor

Salakar commented Aug 31, 2018

@dulmandakh duplicate of #20854

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Aug 31, 2018
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@react-native-bot
Copy link
Collaborator

@dulmandakh merged commit 1edeaef into facebook:master.

Once this commit is added to a release, you will see the corresponding version tag below the description at 1edeaef. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 5, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 5, 2018
gengjiawen pushed a commit to gengjiawen/react-native that referenced this pull request Sep 14, 2018
@dulmandakh @gengjiawen
FIx Android CI (facebook#20901)
60b64ab 
Summary:
This PR fixes Android CI
Pull Request resolved: facebook#20901

Differential Revision: D9596497

Pulled By: hramos

fbshipit-source-id: 5662243645d5d8e51c6da4cb142ab6665a09daee
@dulmandakh dulmandakh deleted the fix-android-ci branch October 15, 2018 16:26
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@dulmandakh @facebook-github-bot
FIx Android CI (facebook#20901)
d30adf5 
Summary:
This PR fixes Android CI
Pull Request resolved: facebook#20901

Differential Revision: D9596497

Pulled By: hramos

fbshipit-source-id: 5662243645d5d8e51c6da4cb142ab6665a09daee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dulmandakh @Salakar @facebook-github-bot @react-native-bot @hramos