Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20991 - use name from app.json if available #20992

Closed
wants to merge 1 commit into from

Conversation

mike-marcacci
Copy link
Contributor

@mike-marcacci mike-marcacci commented Sep 5, 2018

Fix #20991 - use name from app.json if available, instead of using package.json.

Test Plan:

I haven't tested my plan 😬but didn't want to file a trivial, low-priority issue here without a PR, since those just take up space!

Release Notes:

[CLI] [ENHANCEMENT] [react-native-git-upgrade] - Use name from app.json if available

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2018
@hramos
Copy link
Contributor

hramos commented Sep 7, 2018

Looks fine. I'd still like to see a test plan, to make sure this has at least been tested and verified before merging.

This only touches the upgrade CLI, which is not used at Facebook, so any of our contributors should feel free to land this if they approve of the PR.

@mike-marcacci
Copy link
Contributor Author

OK, FWIW I used this change when upgrading @boltline/boltline-native. Upgrading ran into another unrelated issue but the name was no longer a problem. Let me know if anyone has a programatic test strategy you'd like implemented here.

@mikemorris
Copy link

This looks like a good fix to me, only caution is that IIRC iOS preserves AppName app names throughout, while Android downcases to appname when creating directory paths, would want to double-check that behavior stays consistent.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Dec 11, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@mike-marcacci merged commit f59d79c into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 12, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 12, 2018
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants