Fix warning in InputAccessoryView #21174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 18, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@janicduplessis merged commit a0f7d60 into Once this commit is added to a release, you will see the corresponding version tag below the description at a0f7d60. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Currently the warning is always triggered, even on iOS. This simply adds a platform check and tweak the message. Pull Request resolved: facebook#21174 Differential Revision: D9929679 Pulled By: hramos fbshipit-source-id: 383f4a820cf5bf261dbfdcff3b950f9812a65e00
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the warning is always triggered, even on iOS. This simply adds a platform check and tweak the message.
Test Plan:
Check that the warning is no longer triggered in RNTester.
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [BUGFIX] [InputAccessoryView] - Fix warning in InputAccessoryView