SnapshotViewIOS: Remove PropTypes #21294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
elicwhite
approved these changes
Sep 24, 2018
|
@empyrical merged commit 93717e3 into Once this commit is added to a release, you will see the corresponding version tag below the description at 93717e3. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Part of: react-native-community/discussions-and-proposals#29 This PR removes all PropTypes from `SnapshotViewIOS`, and fills out the flow types for its event callbacks. Pull Request resolved: facebook#21294 Differential Revision: D10011659 Pulled By: TheSavior fbshipit-source-id: 28bfa0ab58c0655f9b905d3cb6530b57166c67f9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: react-native-community/discussions-and-proposals#29
This PR removes all PropTypes from
SnapshotViewIOS, and fills out the flow types for its event callbacks.Test Plan:
flow checkpasses!Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/RCTTest/SnapshotViewIOS.ios.js] - Removed all PropTypes