Quote "$NODE_BINARY" in react-native-xcode.sh #21383
Conversation
Fix build errors when path to $NODE_BINARY contains spaces: error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Bump, requesting review please! @TheSavior @rafeca |
|
Looks reasonable to me. 👍 Sorry for not seeing this earlier. We need to get shellcheck set up to make sure we are handling these properly everywhere. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
yungsters is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fix build errors when path to $NODE_BINARY contains spaces: error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle Why would $NODE_BINARY contain spaces? In my case, I am using sentry-cli which wraps the NODE_BINARY in it's own executable. The local path to the project, and thus the $NODE_BINARY, contains a space on my GoCD build agent. '/Users/go/Library/Application Support/Go Agent/pipelines/my-ios-app/node_modules/sentry/cli/sentry-cli See getsentry/sentry-react-native#484 getsentry/sentry-react-native#389 Pull Request resolved: #21383 Differential Revision: D10851141 Pulled By: yungsters fbshipit-source-id: f46853ac8b57957864e0d1a76b8513403223fccb
hramos
removed
Import Started
Summary: Fix build errors when path to $NODE_BINARY contains spaces: error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle Why would $NODE_BINARY contain spaces? In my case, I am using sentry-cli which wraps the NODE_BINARY in it's own executable. The local path to the project, and thus the $NODE_BINARY, contains a space on my GoCD build agent. '/Users/go/Library/Application Support/Go Agent/pipelines/my-ios-app/node_modules/sentry/cli/sentry-cli See getsentry/sentry-react-native#484 getsentry/sentry-react-native#389 Pull Request resolved: facebook#21383 Differential Revision: D10851141 Pulled By: yungsters fbshipit-source-id: f46853ac8b57957864e0d1a76b8513403223fccb
Fix build errors when path to $NODE_BINARY contains spaces:
error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle
Why would $NODE_BINARY contain spaces? In my case, I am using sentry-cli which wraps the NODE_BINARY in it's own executable. The local path to the project, and thus the $NODE_BINARY, contains a space on my GoCD build agent.
'/Users/go/Library/Application Support/Go Agent/pipelines/my-ios-app/node_modules/@sentry/cli/sentry-cli
See getsentry/sentry-react-native#484 getsentry/sentry-react-native#389
Test Plan:
Rebuild with xcode
Release Notes:
[IOS] [BUGFIX] [scripts/react-native-xcode.sh] - Fix build errors when path to $NODE_BINARY contains spaces