Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlowCleanup] Rename and move ViewStylePropTypes #21415

Closed
wants to merge 1 commit into from
Closed

[FlowCleanup] Rename and move ViewStylePropTypes #21415

wants to merge 1 commit into from

Conversation

Thomas0c
Copy link
Contributor

@Thomas0c Thomas0c commented Sep 29, 2018 •
edited
Loading

Related to #21342

  • Renamed ViewStyleProps to DeprecatedViewStyleProps.
  • Moved propType declaration to react-native/Libraries/DeprecatedPropTypes
  • ImageProps.js: moved propType declarations to DeprecatedImageProps.js.

Test Plan:

Ran the following scripts with no errors:

  • npm run prettier
  • npm run flow-check-ios
  • npm run flow-check-android

Release Notes:

[GENERAL] [ENHANCEMENT] [Libraries/Components/View/ViewStyleProps.js] - remove
[GENERAL] [ENHANCEMENT] [Libraries/DeprecatedPropTypes/DeprecatedViewStylePropTypes.js] - created
[GENERAL] [ENHANCEMENT] [Libraries/Animated/src/createAnimatedComponent.js] - renamed ViewStyleProps to DeprecatedViewStyleProps
[GENERAL] [ENHANCEMENT] [Libraries/Components/Slider/Slider.js] - renamed ViewStyleProps to DeprecatedViewStyleProps
[GENERAL] [ENHANCEMENT] [Libraries/Components/View/ReactNativeStyleAttributes.js] - renamed ViewStyleProps to DeprecatedViewStyleProps
[GENERAL] [ENHANCEMENT] [Libraries/DeprecatedPropTypes/DeprecatedViewPropTypes.js] - renamed ViewStyleProps to DeprecatedViewStyleProps
[GENERAL] [ENHANCEMENT] [Libraries/StyleSheet/StyleSheetValidation.js] - renamed ViewStyleProps to DeprecatedViewStyleProps
[GENERAL] [ENHANCEMENT] [Libraries/Text/TextStylePropTypes.js] - renamed ViewStyleProps to DeprecatedViewStyleProps

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

RSNara
RSNara approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

facebook-github-bot
facebook-github-bot reviewed Sep 29, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@Thomas0c merged commit d6f3d37 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 1, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 1, 2018
@hramos hramos changed the title Rename and move ViewStylePropTypes [FlowCleanup] Rename and move ViewStylePropTypes Oct 1, 2018
michalchudziak pushed a commit to michalchudziak/react-native-slider that referenced this pull request Feb 8, 2019
@Thomas0c @facebook-github-bot
Rename and move ViewStylePropTypes (#21415)
808c97d 
Summary:
Related to #21342
* Renamed ViewStyleProps to DeprecatedViewStyleProps.
* Moved propType declaration to `react-native/Libraries/DeprecatedPropTypes`
*  ImageProps.js: moved propType declarations to DeprecatedImageProps.js.
Pull Request resolved: facebook/react-native#21415

Reviewed By: TheSavior

Differential Revision: D10119599

Pulled By: RSNara

fbshipit-source-id: 67674039a88dcd570973c7062f86ebdbd6987d28
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@Thomas0c @facebook-github-bot
Rename and move ViewStylePropTypes (facebook#21415)
bda05f9 
Summary:
Related to facebook#21342
* Renamed ViewStyleProps to DeprecatedViewStyleProps.
* Moved propType declaration to `react-native/Libraries/DeprecatedPropTypes`
*  ImageProps.js: moved propType declarations to DeprecatedImageProps.js.
Pull Request resolved: facebook#21415

Reviewed By: TheSavior

Differential Revision: D10119599

Pulled By: RSNara

fbshipit-source-id: 67674039a88dcd570973c7062f86ebdbd6987d28
james-watkin added a commit to james-watkin/react-native-slider that referenced this pull request Dec 28, 2021
@james-watkin
Rename and move ViewStylePropTypes (#21415)
81ba31d 
Summary:
Related to #21342
* Renamed ViewStyleProps to DeprecatedViewStyleProps.
* Moved propType declaration to `react-native/Libraries/DeprecatedPropTypes`
*  ImageProps.js: moved propType declarations to DeprecatedImageProps.js.
Pull Request resolved: facebook/react-native#21415

Reviewed By: TheSavior

Differential Revision: D10119599

Pulled By: RSNara

fbshipit-source-id: 67674039a88dcd570973c7062f86ebdbd6987d28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@RSNara RSNara RSNara approved these changes

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thomas0c @facebook-github-bot @react-native-bot @RSNara