Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListEmptyComponent is rendered upside down when using inverted flag. #21496

Closed
wants to merge 2 commits into from
Closed

Fix ListEmptyComponent is rendered upside down when using inverted flag. #21496

wants to merge 2 commits into from

Conversation

hyochan
Copy link
Contributor

@hyochan hyochan commented Oct 5, 2018

Fix ListEmptyComponent is rendered upside down when using inverted flag.

Fixes #21196

Test Plan:
Try FlatList with inverted flag like below.

          <FlatList
            style={{
              alignSelf: 'stretch',
              paddingHorizontal: 16 * ratio,
            }}
            ListEmptyComponent={this.renderEmptyView}
            keyExtractor={(item, index) => index.toString()}
            data={ this.state.data }
            renderItem={this.renderUsers}
            inverted={true}
          />

Previous result:
image

Fixed result:
image

Release Notes:
[General] [Fixed] - Fix ListEmptyComponent is rendered upside down when using inverted flag.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2018
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

Libraries/Lists/VirtualizedList.js Outdated Show resolved Hide resolved
@pull-bot
Copy link

pull-bot commented Oct 5, 2018

Warnings
⚠️

📋 Changelog - This PR appears to be missing Changelog.

Generated by 🚫 dangerJS

@hramos hramos changed the title Resolve #21196. Fix ListEmptyComponent is rendered upside down when using inverted flag Oct 5, 2018
@kelset
Copy link
Contributor

kelset commented Nov 20, 2018

It looks some tests are failing, can you add the release notes and rebase your PR?

@cpojer
Copy link
Contributor

cpojer commented Dec 4, 2018

Ping @dooboolab – do you mind following up and rebasing this diff, and possibly adding a test to make sure this is properly working? Then I can quickly land it :)

Fix ListEmptyComponent is rendered upside down, when using inverted flag.
@hyochan
Copy link
Contributor Author

hyochan commented Dec 4, 2018

@cpojer I've just done it. Thank you very much. @kelset Where can I add the release note for this? Could you guide me to this? Sorry, I am quite confused for the first time contributing to this great project.

@kelset
Copy link
Contributor

kelset commented Dec 4, 2018

@dooboolab You already added the release notes in the first comment of this PR, after the "fixed" screenshot :)

We changed slightly the wording for it, so I think that you should change to this:

[General] [Fixed] - Fix ListEmptyComponent is rendered upside down when using inverted flag

BTW I think you, instead of rebasing your PR, merged master into it - which is why now your PR changes almost 1100 files 😅 Maybe it's easier for you to open a new one - or reverse the merge commit. If you need further help, I found this that may help https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request#perform-a-rebase

@hyochan
Copy link
Contributor Author

hyochan commented Dec 4, 2018

@kelset I thanks for the review. Sorry that I've had a mistake with the rebase. @benevbright found my mistake earlier and made the fix on this. By the way, very fast review.

@hyochan hyochan changed the title Fix ListEmptyComponent is rendered upside down when using inverted flag [General] [Fixed] - Fix ListEmptyComponent is rendered upside down when using inverted flag Dec 4, 2018
@hyochan hyochan changed the title [General] [Fixed] - Fix ListEmptyComponent is rendered upside down when using inverted flag Fix ListEmptyComponent is rendered upside down when using inverted flag. Dec 4, 2018
@janicduplessis
Copy link
Contributor

Looks good! Thanks @dooboolab

@janicduplessis
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Dec 5, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@dooboolab merged commit 198eb02 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 5, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 5, 2018
kelset pushed a commit that referenced this pull request Dec 12, 2018
…ag. (#21496)

Summary:
Fix ListEmptyComponent is rendered upside down when using inverted flag.

Fixes #21196
Pull Request resolved: #21496

Differential Revision: D13334437

Pulled By: hramos

fbshipit-source-id: b34a9a0a153862d3d5dbe410ab0a6c66a8cfcffd
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListEmptyComponent is rendered upside down, when using inverted flag
9 participants