-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize scheme for URL on Android #21561
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Generated by 🚫 dangerJS |
@facebook-github-bot shipit |
I cannot do that @dulmandakh, because @radeno does not have an active CLA on file. |
@radeno thank you for the PR. Could you please sign CLA so we can land your PR. |
@dulmandakh done |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@facebook-github-bot shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Android requires lowercase for URL scheme. This commit d00bdb9 fixed it but on React Native side. Because it is Android specific, it should be fixed on Android side. Android has method to normalize url scheme: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme() Pull Request resolved: #21561 Differential Revision: D10287868 Pulled By: hramos fbshipit-source-id: f5e474164fdb2cfd49bd8ee51da17de3f1341a9c
Summary: Android requires lowercase for URL scheme. This commit facebook@d00bdb9 fixed it but on React Native side. Because it is Android specific, it should be fixed on Android side. Android has method to normalize url scheme: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme() Pull Request resolved: facebook#21561 Differential Revision: D10287868 Pulled By: hramos fbshipit-source-id: f5e474164fdb2cfd49bd8ee51da17de3f1341a9c
Android requires lowercase for URL scheme. This commit d00bdb9 fixed it but on React Native side.
Because it is Android specific, it should be fixed on Android side.
Android has method to normalize url scheme: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme()
Test Plan:
Release Notes:
[ANDROID] [BUGFIX] [Component] - Normalize Android URI scheme