Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duration cannot be less then 10ms #21858

Closed
wants to merge 1 commit into from
Closed

Duration cannot be less then 10ms #21858

wants to merge 1 commit into from

Conversation

lbaldy
Copy link
Contributor

@lbaldy lbaldy commented Oct 19, 2018

Related to: #21853

Fixes #21853

Test Plan:

This is an intermittent timing issue. It happens when you scroll quickly from the top to the bottom to dismiss the keyboard, right after a bounce happens in a ScrollView, the duration of the event has to be less than 10ms for the error to occur (see the attached gifs).

fixed
crash

Release Notes:

[IOS] [BUGFIX] [KeyboardAvoidingView] - Fix the crash when transition duration < 10ms

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@hramos
Copy link
Contributor

hramos commented Dec 4, 2018

Thanks for the PR!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Dec 4, 2018
facebook-github-bot
facebook-github-bot approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

Baldy Lukasz merged commit 87b6533 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 4, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 4, 2018
kelset pushed a commit that referenced this pull request Dec 12, 2018
@kelset
Duration cannot be less then 10ms (#21858)
472e978 
Summary:
Related to: #21853

Fixes #21853
Pull Request resolved: #21858

Differential Revision: D13322060

Pulled By: hramos

fbshipit-source-id: 00a8de018fce6507aa131a11ba3e95d57044e683
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React Native “interactive” keyboardDismissMode throws error when dragged
4 participants
@lbaldy @facebook-github-bot @hramos @react-native-bot