Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility Escape #22047

Closed
wants to merge 1 commit into from
Closed

Accessibility Escape #22047

wants to merge 1 commit into from

Conversation

rustle
Copy link
Contributor

@rustle rustle commented Oct 31, 2018

Test Plan:

Validated functionality using RNTester app and VoiceOver.

Release Notes:

[IOS] [ACCESSIBILITY] - Implements accessibility escape gesture prop

@rustle rustle requested a review from shergin as a code owner October 31, 2018 20:31
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests This PR adds or edits a test case. labels Oct 31, 2018
analysis-bot
analysis-bot suggested changes Oct 31, 2018
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

RNTester/js/AccessibilityIOSExample.js Outdated
@@ -26,6 +26,9 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View onAccessibilityEscape={() => alert('onAccessibilityEscape success')} accessible={true}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace ·onAccessibilityEscape={()·=>·alert('onAccessibilityEscape·success')} with ⏎··········onAccessibilityEscape={()·=>·alert('onAccessibilityEscape·success')}⏎·········

RNTester/js/AccessibilityIOSExample.js Outdated
@@ -26,6 +26,9 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View onAccessibilityEscape={() => alert('onAccessibilityEscape success')} accessible={true}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-alert: Unexpected alert.

@pull-bot
Copy link

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

@rustle rustle mentioned this pull request Oct 31, 2018
Merged
@rustle
Copy link
Contributor Author

rustle commented Oct 31, 2018

Documentation PR facebook/react-native-website#655

analysis-bot
analysis-bot suggested changes Oct 31, 2018
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

RNTester/js/AccessibilityIOSExample.js
@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-alert: Unexpected alert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the expectation is here. this example code is consistent with the existing examples.

analysis-bot
analysis-bot suggested changes Nov 12, 2018
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

RNTester/js/AccessibilityIOSExample.js
@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-alert: Unexpected alert.

@shergin
Copy link
Contributor

shergin commented Nov 14, 2018

@rustle Could you please rebase this on master?

@shergin
Copy link
Contributor

shergin commented Nov 14, 2018

... and make prettier happy?

analysis-bot
analysis-bot suggested changes Nov 14, 2018
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

RNTester/js/AccessibilityIOSExample.js
@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-alert: Unexpected alert.

@rustle
Copy link
Contributor Author

rustle commented Nov 14, 2018

@rustle Could you please rebase this on master?

done

@rustle
Copy link
Contributor Author

rustle commented Nov 14, 2018 •
edited
Loading

... and make prettier happy?

npm run prettier doesn't show any issues
npm run lint shows 22:37 warning Unexpected alert no-alert but it's not clear what's expected (to me)

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Nov 20, 2018
facebook-github-bot
facebook-github-bot approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Nov 21, 2018
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@estevaolucas
Copy link

@rustle thanks for adding it. Hopefully, it can be merged "soon". 🤞
(I'm going to need it on my current project)

facebook-github-bot
facebook-github-bot reviewed Dec 7, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer
Copy link
Contributor

cpojer commented Dec 7, 2018

Thanks for working on this. I'm gonna land this PR :)

@react-native-bot
Copy link
Collaborator

@rustle merged commit ee7c702 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 7, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 7, 2018
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Jul 18, 2019
@rustle @facebook-github-bot
Accessibility Escape
deb6023 
Summary: Pull Request resolved: facebook/react-native#22047

Differential Revision: D13146179

Pulled By: cpojer

fbshipit-source-id: b8a089114a5deafee47dd482e484d413c8c39137
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@analysis-bot analysis-bot analysis-bot requested changes

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tests This PR adds or edits a test case.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rustle @pull-bot @shergin @facebook-github-bot @estevaolucas @cpojer @react-native-bot @analysis-bot @hramos