add talkback navigation support for links and header

[yangweigbh]

Summary

1. add role description for heading
2. add talkback navigation support for link and header

Fixes #22440

Test Plan:

1. talkback link navigation for accessibilityRole="link"
2. talkback heading navigation for accessibilityRole="header"
3. talkback reading heading suffix for accessibilityRole="header"
4. talkback link for view component with and without accessibilityHint

Changelog:

[Android] [Changed] - Add talkback navigation support for links and header

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[bartolkaruza]

LGTM

[bartolkaruza]

@yangweigbh can you rebase this onto master? There was a lot of work performed on automated tests recently and the extra coverage for this might be useful.

[yangweigbh]

@bartolkaruza done, but the test_android workflow seems have bug with the following error

Task 'downloadJSCHeaders' not found in project ':ReactAndroid'.

[FLGMwt]

Hi there! excited to see a fix for this issue 💃. Happy to help out if necessary, but the changes don't seem to be related to the CI failure. Might this just need a re-run of the build?

[yangweigbh]

@FLGMwt hi, how to rerun the CI test, i seem to not have the permission to rerun the test

[FLGMwt]

Sorry @yangweigbh, I'm not sure, just another outside consumer of RN. At the very least, I bet a new rebase or empty commit would trigger it.

[FLGMwt]

@yangweigbh Looks like it still failed w/ the retry. Would you mind terribly rebasing this onto latest master again?

[yangweigbh]

@FLGMwt @bartolkaruza thank god, i have finally pass all the CI test, can we merge this PR as this PR has been hang on too long !

[bartolkaruza]

@yangweigbh thanks for taking the time, I'll ask if someone can review this from the core team side over the weekend. Hang tight, you're almost there 👍

[bartolkaruza]

@yangweigbh could you add this

<RNTesterBlock title="Touchable with accessibilityRole = header">
          <View
            accessible={true}
            accessibilityLabel="I'm a header, so I read it instead of embedded text."
            accessibilityRole="header">
            <Text style={{color: 'green'}}>This is</Text>
            <Text style={{color: 'blue'}}>
              nontouchable accessible view with label.
            </Text>
          </View>
        </RNTesterBlock>

        <RNTesterBlock title="Touchable with accessibilityRole = link">
          <TouchableWithoutFeedback
            onPress={() =>
              ToastAndroid.show('Toasts work by default', ToastAndroid.SHORT)
            }
            accessibilityRole="link">
            <View style={styles.embedded}>
              <Text>Click me</Text>
              <Text>Or not</Text>
            </View>
          </TouchableWithoutFeedback>
        </RNTesterBlock>

to https://github.com/yangweigbh/react-native/blob/0b71d176fd13a6cc917d38fbbe4cad28db390809/RNTester/js/AccessibilityAndroidExample.android.js#L112 so that the example in RNTester is still complete after this PR?

I've tested your change on my end and it works like a charm. I'll ask someone to merge after you add that example.

[Tmarie77]

Missing password

[cpojer]

I added the example. I'm not an expert here but I trust @bartolkaruza.

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by Wei Yang in b9d3743.

^{When will my fix make it into a release? | Upcoming Releases}