bump Android Support Library to 28.0.0 #22962
Conversation
facebook-github-bot
added
CLA Signed
|
Looks like CI is failing on test_android. |
dulmandakh
changed the title
Generated by 🚫 dangerJS |
dulmandakh
changed the title
|
@hramos please import this PR and leave comments if failed. Thank you |
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@dulmandakh, thanks for working on this.
I added some comments to make the upgrade of this version of the support library simpler
|
|
||
| fb_native.android_library( | ||
| name = "lib-support-v4", | ||
| visibility = ["PUBLIC"], | ||
| exported_deps = [ | ||
| ":android-lifecycle-common", |
There was a problem hiding this comment.
Can you revert changes in this file?
There was a problem hiding this comment.
And upgrade dependencies from 27.1.1 to 28.0.0 in the original file?
| @@ -24,3 +47,667 @@ fb_native.genrule( | |||
| bash = "ls", | |||
| visibility = ["PUBLIC"], | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Can you revert changes in this file?
| @@ -1,19 +1,42 @@ | |||
| load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") | |||
| load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library") | |||
| load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library", "rn_prebuilt_jar") | |||
There was a problem hiding this comment.
Can you revert changes in this file?
| @@ -1,14 +1,10 @@ | |||
| load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") | |||
| load("//tools/build_defs/oss:rn_defs.bzl", "rn_prebuilt_jar") | |||
| load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep") | |||
There was a problem hiding this comment.
Can you revert changes in this file and upgrade version of support library from 27.1.1 to 28.0.0 in the original file?
| @@ -19,8 +19,7 @@ rn_android_library( | |||
| ":res-for-appcompat", | |||
| ], | |||
| exported_deps = [ | |||
| ":classes-for-react-native", | |||
| react_native_dep("third-party/android/support-annotations:android-support-annotations"), | |||
| react_native_dep("third-party/android/support:appcompat-v7"), | |||
There was a problem hiding this comment.
Can you revert changes in this file?
|
@mdvacca yep, it seems that there is no choice but do everything old way. So I'll create another PR to bump Android Support Library to 28.0.0. |
bump Android Support Library to 28.0.0
Changelog:
[Android] [Changed] - bump Android Support Library to 28.0.0
Test Plan:
CI is green, and everything should work as usual