Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Streamline templates #23107

Closed
wants to merge 1 commit into from
Closed

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Jan 22, 2019

Clarify the purpose of each issue template. Stop accepting discussions here, as there's a separate repository for that purpose.

Changelog:

[General] [Changed] - Streamline issue templates on GitHub.

Test Plan:

Does not apply.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2019

## Reproducible Demo
Let us know how to reproduce the issue. Include a code sample, share a project,
or share an app that reproduces the issue using https://snack.expo.io/.
If you run into an Android or JS build issue, please consider adding CI to your project. Check out https://github.com/react-native-community/ci-sample for how to do this.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gengjiawen I noticed you added this item recently. I am not sure the template is the best place to include this. I'll remove it for now, but happy to discuss further about what you'd like to encourage people to do.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 23, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@hramos merged commit dda193a into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 23, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 23, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
Summary:
Clarify the purpose of each issue template. Stop accepting discussions here, as there's a separate repository for that purpose.

Changelog:
----------

[General] [Changed] - Streamline issue templates on GitHub.
Pull Request resolved: facebook#23107

Differential Revision: D13777281

Pulled By: hramos

fbshipit-source-id: a5b3e790a974a6898d611f0b60f8626e315e7585
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants