-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fixing overscrolling issue on Virtualized List #23181
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending a PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Dustin Savery merged commit 4d5f85e into |
It was pointed out to me that this was not the correct fix for this issue. You should be able to use |
Summary: Changelog: ---------- [iOS][fixed] Fixed overscroll behavior on iOS virtualized lists (Fixes facebook#18098) Pull Request resolved: facebook#23181 Differential Revision: D13838579 Pulled By: cpojer fbshipit-source-id: 2ec5787218ecca0e01aaf31bfbb7d630cf9f1f09
Changelog:
[iOS][fixed] Fixed overscroll behavior on iOS virtualized lists (Fixes #18098)
Test Plan:
Expected: List scrolls to the item to the correct position without overscrolling the list
Actual: List is over scrolling to put the item in the proper position. This causes future scrolling to jump.
Code Used to Test:
Before:
After: