[iOS] Enhance image freshness check before stored into cache #23226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zhongwuzw
commented
Jan 31, 2019
| @@ -31,8 +31,7 @@ typedef dispatch_block_t RCTImageLoaderCancellationBlock; | |||
| size:(CGSize)size | |||
| scale:(CGFloat)scale | |||
| resizeMode:(RCTResizeMode)resizeMode | |||
| responseDate:(NSString *)responseDate | |||
| cacheControl:(NSString *)cacheControl; | |||
There was a problem hiding this comment.
Only pass responseDate or cacheControl may not sufficient, we can just pass response that we can get any response header we want.
react-native-bot
added
Component: Image
Platform: iOS
cpojer
approved these changes
Jan 31, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhongwuzw merged commit e98d5a2 into |
|
Just landed this one again in fb8ba3f |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Currently, before we store the image to cache, we only respect `Cache-Control`, actually, we also may need to check `Expires`、`Last-Modified`, refer to [MDN docs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching#Freshness), and [okhttp](https://github.com/square/okhttp/blob/568a91c44a118b2c2ba62d310a331582c567b24a/okhttp/src/main/java/okhttp3/internal/cache/CacheStrategy.java#L268) respect the `MDN`, so in iOS, we can also respect this. [iOS] [Fixed] - Respect `MDN` cache strategy before cache the image. After `PR`, if image's response do not contains `Cache-Control`, it would also checks `Expires`、`Last-Modified` refers to [MDN docs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching#Freshness). Pull Request resolved: facebook#23226 Differential Revision: D13895627 Pulled By: cpojer fbshipit-source-id: aa377511c31badd752d7887ed6cbcdf6be4b80b3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, before we store the image to cache, we only respect
Cache-Control, actually, we also may need to checkExpires、Last-Modified, refer to MDN docs, and okhttp respect theMDN, so in iOS, we can also respect this.Changelog
[iOS] [Fixed] - Respect
MDNcache strategy before cache the image.Test Plan
After
PR, if image's response do not containsCache-Control, it would also checksExpires、Last-Modifiedrefers to MDN docs.