Fix duplicate symbols linker error in xcodeproj #23284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@tyrone-sudeium merged commit 9f72e6a into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: When using building React Native using the `.xcodeproj` (either via linked projects in Xcode, or precompiling React Native, which is what we do), you'll get a duplicate symbol error: ``` duplicate symbol __ZN8facebook5react10IInspectorD0Ev ... ``` And a few more. This is because the `InspectorInterfaces.cpp` file is included in _both_ the `React` target _and_ the `jsinspector` target, and since the `jsinspector` target gets linked into the `React` target, this means the symbols from `InspectorInterfaces.cpp` end up in `libReact.a` twice. <img width="187" alt="screen shot 2019-02-04 at 11 43 39 am" src="https://user-images.githubusercontent.com/819705/52189088-93190880-288a-11e9-8411-b44b59e8e461.png"> This PR removes `InspectorInterfaces.cpp` from the `React` target, as I believe was the original intent. Since this bug is in the `xcodeproj` it only affects builds that use that, so CocoaPods and Buck users are unaffected. [iOS][Fixed] - Fix potential linker issues when using xcode project Pull Request resolved: facebook#23284 Differential Revision: D13941777 Pulled By: cpojer fbshipit-source-id: 8a3ffb4fc916ff6570bbff8794b4515b48055667
grabbou
pushed a commit
that referenced
this pull request
Feb 18, 2019
Summary: When using building React Native using the `.xcodeproj` (either via linked projects in Xcode, or precompiling React Native, which is what we do), you'll get a duplicate symbol error: ``` duplicate symbol __ZN8facebook5react10IInspectorD0Ev ... ``` And a few more. This is because the `InspectorInterfaces.cpp` file is included in _both_ the `React` target _and_ the `jsinspector` target, and since the `jsinspector` target gets linked into the `React` target, this means the symbols from `InspectorInterfaces.cpp` end up in `libReact.a` twice. <img width="187" alt="screen shot 2019-02-04 at 11 43 39 am" src="https://user-images.githubusercontent.com/819705/52189088-93190880-288a-11e9-8411-b44b59e8e461.png"> This PR removes `InspectorInterfaces.cpp` from the `React` target, as I believe was the original intent. Since this bug is in the `xcodeproj` it only affects builds that use that, so CocoaPods and Buck users are unaffected. [iOS][Fixed] - Fix potential linker issues when using xcode project Pull Request resolved: #23284 Differential Revision: D13941777 Pulled By: cpojer fbshipit-source-id: 8a3ffb4fc916ff6570bbff8794b4515b48055667
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: When using building React Native using the `.xcodeproj` (either via linked projects in Xcode, or precompiling React Native, which is what we do), you'll get a duplicate symbol error: ``` duplicate symbol __ZN8facebook5react10IInspectorD0Ev ... ``` And a few more. This is because the `InspectorInterfaces.cpp` file is included in _both_ the `React` target _and_ the `jsinspector` target, and since the `jsinspector` target gets linked into the `React` target, this means the symbols from `InspectorInterfaces.cpp` end up in `libReact.a` twice. <img width="187" alt="screen shot 2019-02-04 at 11 43 39 am" src="https://user-images.githubusercontent.com/819705/52189088-93190880-288a-11e9-8411-b44b59e8e461.png"> This PR removes `InspectorInterfaces.cpp` from the `React` target, as I believe was the original intent. Since this bug is in the `xcodeproj` it only affects builds that use that, so CocoaPods and Buck users are unaffected. [iOS][Fixed] - Fix potential linker issues when using xcode project Pull Request resolved: facebook#23284 Differential Revision: D13941777 Pulled By: cpojer fbshipit-source-id: 8a3ffb4fc916ff6570bbff8794b4515b48055667
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using building React Native using the
.xcodeproj(either via linked projects in Xcode, or precompiling React Native, which is what we do), you'll get a duplicate symbol error:And a few more.
This is because the
InspectorInterfaces.cppfile is included in both theReacttarget and thejsinspectortarget, and since thejsinspectortarget gets linked into theReacttarget, this means the symbols fromInspectorInterfaces.cppend up inlibReact.atwice.This PR removes
InspectorInterfaces.cppfrom theReacttarget, as I believe was the original intent.Since this bug is in the
xcodeprojit only affects builds that use that, so CocoaPods and Buck users are unaffected.Changelog
[iOS][Fixed] - Fix potential linker issues when using xcode project
Test Plan
Only affects the
xcodeproj, and the project still builds with zero errors from thexcodeproj.