Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Image displayName, currently displaying as <Component> in tests #23287

Closed
wants to merge 1 commit into from
Closed

Fix for Image displayName, currently displaying as <Component> in tests #23287

wants to merge 1 commit into from

Conversation

linnett
Copy link
Contributor

@linnett linnett commented Feb 4, 2019 •
edited
Loading

Summary

As per #21937, Image displayName is not set. This means it comes through as <Component> in tests.

Changelog

[General][fixed] - fix displayName for Image

Test Plan

As there were only a couple of files changed, I amended the files directly in the node_modules to test and it worked as expected.
component.debug() in Jest now shows <Image... rather than <Component...

@linnett linnett requested a review from shergin as a code owner February 4, 2019 14:12
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@linnett linnett mentioned this pull request Feb 4, 2019
Closed
3 tasks
@pull-bot
Copy link

pull-bot commented Feb 4, 2019

Warnings
⚠️

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

cpojer
cpojer approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 4, 2019
facebook-github-bot
facebook-github-bot approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@linnett merged commit 4989123 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 4, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 4, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@linnett @facebook-github-bot
Fix for Image displayName, currently displaying as <Component> in tes…
0c5d672 
…ts (facebook#23287)

Summary:
As per facebook#21937, Image `displayName` is not set. This means it comes through as `<Component>` in tests.

[General][fixed] - fix `displayName` for `Image`
Pull Request resolved: facebook#23287

Differential Revision: D13941744

Pulled By: cpojer

fbshipit-source-id: eab161eee415ec4f7207efcd5c6e2a4bbe67dfe1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@cpojer cpojer cpojer approved these changes

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: Image Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@linnett @facebook-github-bot @pull-bot @react-native-bot @cpojer @hramos