Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the unused packages from package.json #23428

Closed
wants to merge 1 commit into from

Conversation

nimish-gupta
Copy link
Contributor

Summary

There are couple of packages which are installed as dependency but are not directly used in the project. In this PR I have remove those packages from dependency from the package.json.

Changelog

[General] [Removed] - Remove the unused packages from package.json

Test Plan

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 7a233da

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer
Copy link
Contributor

cpojer commented Feb 13, 2019

This is awesome! @nimish-gupta can you walk me through the process you used to find unused dependencies? I wanna just make sure we aren't removing anything that we still need.

@gengjiawen
Copy link
Contributor

Do they originally belong to react-native-cli ?

@cpojer
Copy link
Contributor

cpojer commented Feb 13, 2019

@gengjiawen yes, or Metro. See #23313 for more information.

@nimish-gupta
Copy link
Contributor Author

@cpojer for removing the packages

  • I just search the dependencies through out the repo, and if that is not used from anywhere I just removed it.
  • I also did yarn remove but it doesn't cause any change because these dependencies are indirectly used by different packages.

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome. Let me check internally at FB if this causes any issues and then land it. Thank you so much for doing this clean up.

As a next step, do you think you could identify the largest dependencies and make an issue so we can analyze which ones we may want to consider stripping? Thank you!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@nimish-gupta
Copy link
Contributor Author

@cpojer yeah sure I will work on this one.

As a next step, do you think you could identify the largest dependencies and make an issue so we can analyze which ones we may want to consider stripping? Thank you!

@dalcib
Copy link
Contributor

dalcib commented Feb 14, 2019

It seems that lodash is no longer used either.
https://github.com/facebook/react-native/search?q=lodash&type=Code

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer
Copy link
Contributor

cpojer commented Feb 14, 2019

Importing again because there was an issue yesterday…

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 14, 2019
@react-native-bot
Copy link
Collaborator

@nimish-gupta merged commit a063435 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 14, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 14, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants