react_native_config available to all Android versions #23470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
Platform: Android
cpojer
approved these changes
Feb 15, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit 19492b7 into |
grabbou
pushed a commit
that referenced
this pull request
Feb 15, 2019
Summary: Move react_native_config.xml so that it's available to all Android versions, and fixes #23445. It's my bad, I should've tested previous change on multiple versions of Android. [Android] [Changed] - Fix network security Pull Request resolved: #23470 Differential Revision: D14099612 Pulled By: cpojer fbshipit-source-id: 15b5e5f575de8033bbfd524d9ad2aa0e22daa813
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move react_native_config.xml so that it's available to all Android versions, and fixes #23445. It's my bad, I should've tested previous change on multiple versions of Android.
Changelog
[Android] [Changed] - Fix network security
Test Plan
CI is green and #23445 gone.