-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYSTEM_ALERT_WINDOW only in debug builds #23504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@dulmandakh merged commit 84a2fb0 into |
@dulmandakh Can you import the related change to RNTester ? |
Summary: SYSTEM_ALERT_WINDOW permission is used only for debug builds to show draw overlay views or show warnings/errors. This permissions is unused in release builds, and there is an issue regarding removing unused permissions on Android build facebook#5886 (comment). This PR removes SYSTEM_ALERT_WINDOW from all builds bug debug. [Android] [Changed] - SYSTEM_ALERT_WINDOW permissions available only in debug builds Pull Request resolved: facebook#23504 Differential Revision: D14123045 Pulled By: cpojer fbshipit-source-id: 68829a774ff23c7cb2721076a9d3870405f48fea
Summary: SYSTEM_ALERT_WINDOW permission is used only for debug builds to show draw overlay views or show warnings/errors. This permissions is unused in release builds, and there is an issue regarding removing unused permissions on Android build #5886 (comment). This PR removes SYSTEM_ALERT_WINDOW from all builds bug debug. [Android] [Changed] - SYSTEM_ALERT_WINDOW permissions available only in debug builds Pull Request resolved: #23504 Differential Revision: D14123045 Pulled By: cpojer fbshipit-source-id: 68829a774ff23c7cb2721076a9d3870405f48fea
Summary
SYSTEM_ALERT_WINDOW permission is used only for debug builds to show draw overlay views or show warnings/errors. This permissions is unused in release builds, and there is an issue regarding removing unused permissions on Android build #5886 (comment). This PR removes SYSTEM_ALERT_WINDOW from all builds bug debug.
Changelog
[Android] [Changed] - SYSTEM_ALERT_WINDOW permissions available only in debug builds
Test Plan
CI is green, and I tested it in my apps.